summaryrefslogtreecommitdiff
path: root/CodingStyle
AgeCommit message (Expand)AuthorFilesLines
2013-05-10docs: minor: fix mentioning of Documentation/Daniel Borkmann1-1/+1
2013-04-11docs: move some of them to the root directoryDaniel Borkmann1-0/+833
info' class='commit-info'> authorBob Liu <bob.liu@oracle.com>2016-06-07 10:43:15 -0400 committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>2016-06-08 13:54:39 -0400 commitefd1535270c1deb0487527bf0c3c827301a69c93 (patch) treee0afb0ad9d8e7db1ed1d52ba4c07e2278ff2b7c4 /Documentation parent116f7d4a21fe450efc652c4850eb27cda36c9db0 (diff)
xen-blkfront: don't call talk_to_blkback when already connected to blkback
Sometimes blkfront may twice receive blkback_changed() notification (XenbusStateConnected) after migration, which will cause talk_to_blkback() to be called twice too and confuse xen-blkback. The flow is as follow: blkfront blkback blkfront_resume() > talk_to_blkback() > Set blkfront to XenbusStateInitialised front changed() > Connect() > Set blkback to XenbusStateConnected blkback_changed() > Skip talk_to_blkback() because frontstate == XenbusStateInitialised > blkfront_connect() > Set blkfront to XenbusStateConnected ----- And here we get another XenbusStateConnected notification leading to: ----- blkback_changed() > because now frontstate != XenbusStateInitialised talk_to_blkback() is also called again > blkfront state changed from XenbusStateConnected to XenbusStateInitialised (Which is not correct!) front_changed(): > Do nothing because blkback already in XenbusStateConnected Now blkback is in XenbusStateConnected but blkfront is still in XenbusStateInitialised - leading to no disks. Poking of the XenbusStateConnected state is allowed (to deal with block disk change) and has to be dealt with. The most likely cause of this bug are custom udev scripts hooking up the disks and then validating the size. Signed-off-by: Bob Liu <bob.liu@oracle.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Diffstat (limited to 'Documentation')