// myLine.cpp // // 13 Jun 93 Init array[0] = NUL in case it is reference before use // memcpy() adjusted to also copy terminating NUL from is.get() // when extending buffer // # include # include "myLine.h" # if defined(_MSC_VER) # include # else # include # endif // Class implementation myLine::myLine (short buflen) : len(buflen), mybuf(new char[len]), xalloc(1) { mybuf[0] = 0; } myLine::myLine (char * usebuf, short buflen) : len(buflen), mybuf(usebuf), xalloc(0) { mybuf[0] = 0; } myLine::~myLine (void) { if (xalloc) delete [] mybuf; } istream & operator>> (istream & is, myLine & l) { # if AUTO_GROW if (!l.xalloc) // It's not my buf, so it can't be grown { # endif is.get (l.mybuf, l.len); if (is.peek() == '\n') is.get(); // Remove newline from stream # if AUTO_GROW } else { int idx = 0; l.mybuf[0] = 0; // Terminate in case is.good() isn't for (int eol = 0; !eol && is.good(); ) { int toget = l.len - idx; is.get (l.mybuf + idx, toget); int chrs = is.gcount(); if (is.peek() == '\n') { ++eol; // Must be eol or eof is.get(); // Clear newline } else if (chrs) { // Extend buffer idx += chrs; // Add to index l.len = short(l.len + ALLOC_LEN); char * tmp = new char[l.len]; memcpy (tmp, l.mybuf, idx + 1); delete [] l.mybuf; l.mybuf = tmp; } } } # endif return is; } >logtreecommitdiff
diff options
context:
space:
mode:
authorLaura Abbott <labbott@redhat.com>2016-12-21 12:32:54 -0800
committerHerbert Xu <herbert@gondor.apana.org.au>2016-12-27 17:32:11 +0800
commit02608e02fbec04fccf2eb0cc8d8082f65c0a4286 (patch)
tree37ff0410d130cfe77185f591b07cd6403f207f0c /sound/atmel
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
crypto: testmgr - Use heap buffer for acomp test input
Christopher Covington reported a crash on aarch64 on recent Fedora kernels: kernel BUG at ./include/linux/scatterlist.h:140! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 752 Comm: cryptomgr_test Not tainted 4.9.0-11815-ge93b1cc #162 Hardware name: linux,dummy-virt (DT) task: ffff80007c650080 task.stack: ffff800008910000 PC is at sg_init_one+0xa0/0xb8 LR is at sg_init_one+0x24/0xb8 ... [<ffff000008398db8>] sg_init_one+0xa0/0xb8 [<ffff000008350a44>] test_acomp+0x10c/0x438 [<ffff000008350e20>] alg_test_comp+0xb0/0x118 [<ffff00000834f28c>] alg_test+0x17c/0x2f0 [<ffff00000834c6a4>] cryptomgr_test+0x44/0x50 [<ffff0000080dac70>] kthread+0xf8/0x128 [<ffff000008082ec0>] ret_from_fork+0x10/0x50 The test vectors used for input are part of the kernel image. These inputs are passed as a buffer to sg_init_one which eventually blows up with BUG_ON(!virt_addr_valid(buf)). On arm64, virt_addr_valid returns false for the kernel image since virt_to_page will not return the correct page. Fix this by copying the input vectors to heap buffer before setting up the scatterlist. Reported-by: Christopher Covington <cov@codeaurora.org> Fixes: d7db7a882deb ("crypto: acomp - update testmgr with support for acomp") Signed-off-by: Laura Abbott <labbott@redhat.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'sound/atmel')