diff options
| author | Tobias Klauser <tklauser@distanz.ch> | 2009-05-23 15:14:45 +0200 |
|---|---|---|
| committer | Tobias Klauser <tklauser@distanz.ch> | 2009-05-23 15:14:45 +0200 |
| commit | e016103fa25167594b9ff5d410019f114b7a36fb (patch) | |
| tree | 0fd8b5b9c824f3611c24ed00dcbc2058579e15a1 /src/display.c | |
| parent | 04b38c4c173cef3b1b12163f1cf5a9b3cef8cb4a (diff) | |
New upstream release 15.7a, fixing CVE-2009-014815-7a-1
Diffstat (limited to 'src/display.c')
| -rw-r--r-- | src/display.c | 28 |
1 files changed, 10 insertions, 18 deletions
diff --git a/src/display.c b/src/display.c index 7ef03cb..2af0e6c 100644 --- a/src/display.c +++ b/src/display.c @@ -62,7 +62,7 @@ typedef jmp_buf sigjmp_buf; #endif -static char const rcsid[] = "$Id: display.c,v 1.29 2006/08/20 15:00:34 broeker Exp $"; +static char const rcsid[] = "$Id: display.c,v 1.30 2009/04/10 13:39:23 broeker Exp $"; int booklen; /* OGS book name display field length */ int *displine; /* screen line of displayed reference */ @@ -478,20 +478,20 @@ search(void) /* see if it is empty */ if ((c = getc(refsfound)) == EOF) { if (findresult != NULL) { - (void) sprintf(lastmsg, "Egrep %s in this pattern: %s", + (void) snprintf(lastmsg, sizeof(lastmsg), "Egrep %s in this pattern: %s", findresult, Pattern); } else if (rc == NOTSYMBOL) { - (void) sprintf(lastmsg, "This is not a C symbol: %s", + (void) snprintf(lastmsg, sizeof(lastmsg), "This is not a C symbol: %s", Pattern); } else if (rc == REGCMPERROR) { - (void) sprintf(lastmsg, "Error in this regcomp(3) regular expression: %s", + (void) snprintf(lastmsg, sizeof(lastmsg), "Error in this regcomp(3) regular expression: %s", Pattern); } else if (funcexist == NO) { - (void) sprintf(lastmsg, "Function definition does not exist: %s", + (void) snprintf(lastmsg, sizeof(lastmsg), "Function definition does not exist: %s", Pattern); } else { - (void) sprintf(lastmsg, "Could not find the %s: %s", + (void) snprintf(lastmsg, sizeof(lastmsg), "Could not find the %s: %s", fields[field].text2, Pattern); } return(NO); @@ -527,17 +527,17 @@ progress(char *what, long current, long max) move(MSGLINE, 0); clrtoeol(); addstr(what); - sprintf(msg, "%ld", current); + snprintf(msg, sizeof(msg), "%ld", current); move(MSGLINE, (COLS / 2) - (strlen(msg) / 2)); addstr(msg); - sprintf(msg, "%ld", max); + snprintf(msg, sizeof(msg), "%ld", max); move(MSGLINE, COLS - strlen(msg)); addstr(msg); refresh(); } else if (verbosemode == YES) { - sprintf(msg, "> %s %ld of %ld", what, current, max); + snprintf(msg, sizeof(msg), "> %s %ld of %ld", what, current, max); } start = now; @@ -575,7 +575,7 @@ myperror(char *text) s = sys_errlist[errno]; } #endif - (void) sprintf(msg, "%s: %s", text, s); + (void) snprintf(msg, sizeof(msg), "%s: %s", text, s); postmsg(msg); } @@ -647,11 +647,7 @@ posterr(char *msg, ...) (void) vfprintf(stderr, msg, ap); (void) fputc('\n', stderr); } else { -#if HAVE_VSNPRINTF vsnprintf(errbuf, sizeof(errbuf), msg, ap); -#else - vsprintf(errbuf, msg, ap); -#endif postmsg2(errbuf); } } @@ -664,11 +660,7 @@ postfatal(const char *msg, ...) char errbuf[MSGLEN]; va_start(ap, msg); -#if HAVE_VSNPRINTF vsnprintf(errbuf, sizeof(errbuf), msg, ap); -#else - vsprintf(errbuf, msg, ap); -#endif /* restore the terminal to its original mode */ if (incurses == YES) { exitcurses(); |