summaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorGeert Uytterhoeven <geert+renesas@glider.be>2016-10-28 07:07:47 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-10-28 08:13:07 -0400
commit4dda864d73079a1eb01fab4ec29b97db150163bf (patch)
treee44f9cc78700fc39ee8b7b453b06c1e524f54ed9 /Documentation
parent9bcffe7575b721d7b6d9b3090fe18809d9806e78 (diff)
tty: serial_core: Fix serial console crash on port shutdown
The port->console flag is always false, as uart_console() is called before the serial console has been registered. Hence for a serial port used as the console, uart_tty_port_shutdown() will still be called when userspace closes the port, powering it down. This may lead to a system lock up when the serial console driver writes to the serial port's registers. To fix this, move the setting of port->console after the call to uart_configure_port(), which registers the serial console. Fixes: 761ed4a94582ab29 ("tty: serial_core: convert uart_close to use tty_port_close") Reported-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Rob Herring <robh@kernel.org> Tested-by: Mugunthan V N <mugunthanvnm@ti.com> Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> [robh: rebased on tty-linus] Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions