summaryrefslogtreecommitdiff
path: root/Documentation
diff options
context:
space:
mode:
authorNiu Yawei <yawei.niu@intel.com>2016-09-18 16:38:14 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-09-19 09:51:51 +0200
commiteda3565c3654fe98b2f7b61db0ad0307672fa25d (patch)
tree27b7bccb5c0f0660e7c4c2408299ac7e5fb45a07 /Documentation
parent347c7aed9e1b009a0d1bc7defdf93d3a760817a0 (diff)
staging: lustre: recovery: don't replay closed open
To avoid scanning the replay open list every time in the ptlrpc_free_committed(), the fix of LU-2613 (4322e0f9) changed the ptlrpc_free_committed() to skip the open list unless the import generation is changed. That introduced a race which could make a closed open being replayed: 1. Application calls ll_close_inode_openhandle()-> mdc_close(), to close file, rq_replay is cleared, but the open request is still on the imp_committed_list; 2. Before the md_clear_open_replay_data() is called for close, client start replay, and that closed open will be replayed mistakenly; 3. Open replay interpret callback (mdc_replay_open) could race with the mdc_clear_open_replay_data() at the end; This patch fix the ptlrpc_free_committed() to make sure the open list is scanned on recovery to prevent the closed open request from being replayed. Signed-off-by: Niu Yawei <yawei.niu@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5507 Reviewed-on: http://review.whamcloud.com/12667 Reviewed-by: Lai Siyao <lai.siyao@intel.com> Reviewed-by: Andreas Dilger <andreas.dilger@intel.com> Reviewed-by: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by: James Simmons <jsimmons@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions