diff options
author | Peter Rosin <peda@axentia.se> | 2016-12-17 21:29:11 +0100 |
---|---|---|
committer | Wolfram Sang <wsa@the-dreams.de> | 2016-12-18 08:54:38 +0100 |
commit | 649ac63a9ae5e08b7123f2fa98c2bf42f033bdb9 (patch) | |
tree | 6e571792c6101cbe1d59f52db24e4f6562b21826 /include/dt-bindings | |
parent | 8e598769c55dd6c442a1c6cbd21e7abda2a52215 (diff) |
i2c: mux: mlxcpld: fix i2c mux selection caching
smbus functions return -ve on error, 0 on success. However,
__i2c_transfer() have a different return signature - -ve on error, or
number of buffers transferred (which may be zero or greater).
The upshot of this is that the sense of the test is reversed when using
the mux on a bus supporting the master_xfer method: we cache the value
and never retry if we fail to transfer any buffers, but if we succeed,
we clear the cached value.
Fix this by making mlxcpld_mux_reg_write() return a -ve error code for
all failure cases, just as was done in commit 7f638c1cb0a1 ("i2c: mux:
pca954x: fix i2c mux selection caching").
This also aligns the implementations of these two muxes in this area.
Signed-off-by: Peter Rosin <peda@axentia.se>
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Diffstat (limited to 'include/dt-bindings')
0 files changed, 0 insertions, 0 deletions