summaryrefslogtreecommitdiff
path: root/net/irda
diff options
context:
space:
mode:
authorYuchung Cheng <ycheng@google.com>2017-01-27 16:24:39 -0800
committerDavid S. Miller <davem@davemloft.net>2017-01-29 19:17:23 -0500
commit678550c651aee051d66112933c87894f129b9355 (patch)
treeed24210650990895c35fbae14f84237f8c0fccd2 /net/irda
parent7e98102f489775d8c000884fca8a0d995ea688a9 (diff)
tcp: include locally failed retries in retransmission stats
Currently the retransmission stats are not incremented if the retransmit fails locally. But we always increment the other packet counters that track total packet/bytes sent. Awkwardly while we don't count these failed retransmits in RETRANSSEGS, we do count them in FAILEDRETRANS. If the qdisc is dropping many packets this could under-estimate TCP retransmission rate substantially from both SNMP or per-socket TCP_INFO stats. This patch changes this by always incrementing retransmission stats on retransmission attempts and failures. Another motivation is to properly track retransmists in SCM_TIMESTAMPING_OPT_STATS. Since SCM_TSTAMP_SCHED collection is triggered in tcp_transmit_skb(), If tp->total_retrans is incremented after the function, we'll always mis-count by the amount of the latest retransmission. Signed-off-by: Yuchung Cheng <ycheng@google.com> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com> Acked-by: Neal Cardwell <ncardwell@google.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda')
0 files changed, 0 insertions, 0 deletions