cfg80211 debugfs: Cleanup some checkpatch issues - net-next.git - net-next plumbings

summary refs log tree commit diff

path: root/tools/arch

diff options

author	Pichugin Dmitry <smokeman85@gmail.com>	2017-01-28 17:06:53 +0300
committer	Johannes Berg <johannes.berg@intel.com>	2017-02-08 09:15:59 +0100
commit	b699b71d82e77203be43bda5ff1b72516f129581 (patch)
tree	51f9589974f3f58fd2e26660f4dec51a4a267d43 /tools/arch
parent	bddb2afcb6c52a545f18fb9bcd4829828ebf4a3a (diff)

cfg80211 debugfs: Cleanup some checkpatch issues

This fixes the checkpatch.pl warnings: * Macros should not use a trailing semicolon. * Spaces required around that '='. * Symbolic permissions 'S_IRUGO' are not preferred. Signed-off-by: Dmitriy Pichugin <smokeman85@gmail.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Diffstat (limited to 'tools/arch')

0 files changed, 0 insertions, 0 deletions

h->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Diffstat (limited to 'include/trace/events/skb.h')