sfc: fix an off-by-one compare on an array size - net-next.git - net-next plumbings

summary refs log tree commit diff

path: root/tools/build/feature/test-libelf-getshdrstrndx.c

diff options

author	Colin Ian King <colin.king@canonical.com>	2017-01-31 16:30:02 +0000
committer	David S. Miller <davem@davemloft.net>	2017-01-31 12:25:32 -0500
commit	e9904990e8e70a51574e6ec6b872f3c705ec75f0 (patch)
tree	f09f227119e074b485f55a45c0cb6aa4460a4f21 /tools/build/feature/test-libelf-getshdrstrndx.c
parent	1bae6c99decf9137069646b593d3439171a8a8e2 (diff)

sfc: fix an off-by-one compare on an array size

encap_type should be checked to see if it is greater or equal to the size of array map to fix an off-by-one array size check. This fixes an array overrun read as detected by static analysis by CoverityScan, CID#1398883 ("Out-of-bounds-read") Fixes: 9b41080125176841e ("sfc: insert catch-all filters for encapsulated traffic") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Edward Cree <ecree@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>

Diffstat (limited to 'tools/build/feature/test-libelf-getshdrstrndx.c')

0 files changed, 0 insertions, 0 deletions

zed: clear a bit in a byte, and test the sign bit. Nick doesn't love the resulting name of the new primitive, but I'd rather make the name be descriptive and very clear about the limitation imposed by trying to work across all relevant architectures than make it be some generic thing that doesn't make the odd semantics explicit. So this introduces the new architecture primitive clear_bit_unlock_is_negative_byte(); and adds the trivial implementation for x86. We have a generic non-optimized fallback (that just does a "clear_bit()"+"test_bit(7)" combination) which can be overridden by any architecture that can do better. According to Nick, Power has the same hickup x86 has, for example, but some other architectures may not even care. All these optimizations mean that my page locking stress-test (which is just executing a lot of small short-lived shell scripts: "make test" in the git source tree) no longer makes our page locking look horribly bad. Before all these optimizations, just the unlock_page() costs were just over 3% of all CPU overhead on "make test". After this, it's down to 0.66%, so just a quarter of the cost it used to be. (The difference on NUMA is bigger, but there this micro-optimization is likely less noticeable, since the big issue on NUMA was not the accesses to 'struct page', but the waitqueue accesses that were already removed by Nick's earlier commit). Acked-by: Nick Piggin <npiggin@gmail.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Bob Peterson <rpeterso@redhat.com> Cc: Steven Whitehouse <swhiteho@redhat.com> Cc: Andrew Lutomirski <luto@kernel.org> Cc: Andreas Gruenbacher <agruenba@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Mel Gorman <mgorman@techsingularity.net> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Diffstat (limited to 'net/dccp/feat.h')