diff options
| author | Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz> | 2016-12-08 11:43:34 +1300 |
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2016-12-11 11:19:04 +0100 |
| commit | edb6fa1a6452edf736c04d02e3f6de59043df69e (patch) | |
| tree | f854dd896b1e5033a26f305ec9a50a87b1b13939 /drivers | |
| parent | 3e5de27e940d00d8d504dfb96625fb654f641509 (diff) | |
MIPS: Return -ENODEV from weak implementation of rtc_mips_set_time
The sync_cmos_clock function in kernel/time/ntp.c first tries to update
the internal clock of the cpu by calling the "update_persistent_clock64"
architecture specific function. If this returns -ENODEV, it then tries
to update an external RTC using "rtc_set_ntp_time".
On the mips architecture, the weak implementation of the underlying
function would return 0 if it wasn't overridden. This meant that the
sync_cmos_clock function would never try to update an external RTC
(if both CONFIG_GENERIC_CMOS_UPDATE and CONFIG_RTC_SYSTOHC are
configured)
Returning -ENODEV instead, means that an external RTC will be tried.
Signed-off-by: Luuk Paulussen <luuk.paulussen@alliedtelesis.co.nz>
Reviewed-by: Richard Laing <richard.laing@alliedtelesis.co.nz>
Reviewed-by: Scott Parlane <scott.parlane@alliedtelesis.co.nz>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/14649/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'drivers')