62970085ebedc73ec8dfd14 Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Wed, 25 Jan 2017 11:39:50 +0100
Subject: net: phy: leds: Fix truncated LED trigger names

Commit 4567d686f5c6d955 ("phy: increase size of MII_BUS_ID_SIZE and
bus_id") increased the size of MII bus IDs, but forgot to update the
private definition in <linux/phy_led_triggers.h>.
This may cause:
  1. Truncation of LED trigger names,
  2. Duplicate LED trigger names,
  3. Failures registering LED triggers,
  4. Crashes due to bad error handling in the LED trigger failure path.

To fix this, and prevent the definitions going out of sync again in the
future, let the PHY LED trigger code use the existing MII_BUS_ID_SIZE
definition.

Example:
  - Before I had triggers "ee700000.etherne:01:100Mbps" and
    "ee700000.etherne:01:10Mbps",
  - After the increase of MII_BUS_ID_SIZE, both became
    "ee700000.ethernet-ffffffff:01:" => FAIL,
  - Now, the triggers are "ee700000.ethernet-ffffffff:01:100Mbps" and
    "ee700000.ethernet-ffffffff:01:10Mbps", which are unique again.

Fixes: 4567d686f5c6d955 ("phy: increase size of MII_BUS_ID_SIZE and bus_id")
Fixes: 2e0bc452f4721520 ("net: phy: leds: add support for led triggers on phy link state change")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
loop-back</option>
<option value='packet-rx-pump-back'>packet-rx-pump-back</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?id=7a7b5df84b6b4e5d599c7289526eed96541a0654'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/include/uapi/drm/vmwgfx_drm.h'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/include/uapi/drm/vmwgfx_drm.h?id=7a7b5df84b6b4e5d599c7289526eed96541a0654'>tree</a><a href='/cgit.cgi/linux/net-next.git/commit/include/uapi/drm/vmwgfx_drm.h?id=7a7b5df84b6b4e5d599c7289526eed96541a0654'>commit</a><a class='active' href='/cgit.cgi/linux/net-next.git/diff/include/uapi/drm/vmwgfx_drm.h?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/include/uapi/drm/vmwgfx_drm.h'>
<input type='hidden' name='id' value='7a7b5df84b6b4e5d599c7289526eed96541a0654'/><input type='hidden' name='id2' value='877a021e08ccb6434718c0cc781fdf943c884cc0'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/diff/?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>root</a>/<a href='/cgit.cgi/linux/net-next.git/diff/include?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>include</a>/<a href='/cgit.cgi/linux/net-next.git/diff/include/uapi?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>uapi</a>/<a href='/cgit.cgi/linux/net-next.git/diff/include/uapi/drm?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>drm</a>/<a href='/cgit.cgi/linux/net-next.git/diff/include/uapi/drm/vmwgfx_drm.h?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>vmwgfx_drm.h</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='id' value='7a7b5df84b6b4e5d599c7289526eed96541a0654'/><input type='hidden' name='id2' value='877a021e08ccb6434718c0cc781fdf943c884cc0'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?id=7a7b5df84b6b4e5d599c7289526eed96541a0654&amp;id2=877a021e08ccb6434718c0cc781fdf943c884cc0'>Diffstat</a> (limited to 'include/uapi/drm/vmwgfx_drm.h')</div><table summary='diffstat' class='diffstat'>