plumbings</title>
<meta name='generator' content='cgit v1.2.3-54-g00ecf'/>
<meta name='robots' content='noindex, nofollow'/>
<link rel='stylesheet' type='text/css' href='/cgit.css'/>
<script type='text/javascript' src='/cgit.js'></script>
<link rel='shortcut icon' href='http://distanz.ch/favicon.ico'/>
<link rel='alternate' title='Atom feed' href='https://git.distanz.ch/cgit.cgi/linux/net-next.git/atom/drivers/usb/core/hub.c?h=master' type='application/atom+xml'/>
<link rel='vcs-git' href='git://git.distanz.ch/linux/net-next.git' title='net-next.git Git repository'/>
<link rel='vcs-git' href='http:///git.distanz.ch/cgit.cgi/linux/net-next.git' title='net-next.git Git repository'/>
</head>
<body>
<div id='cgit'><table id='header'>
<tr>
<td class='logo' rowspan='2'><a href='/cgit.cgi/'><img src='/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/cgit.cgi/'>index</a> : <a href='/cgit.cgi/linux/net-next.git/'>net-next.git</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='b17c1bba9cec1727451b906d9a0c209774624873'/><select name='h' onchange='this.form.submit();'>
<option value='emaclite-cleanup'>emaclite-cleanup</option>
<option value='master' selected='selected'>master</option>
<option value='nds-private-remove'>nds-private-remove</option>
<option value='packet-loop-back'>packet-loop-back</option>
<option value='packet-rx-pump-back'>packet-rx-pump-back</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?id=b17c1bba9cec1727451b906d9a0c209774624873'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/drivers/usb/core/hub.c'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/drivers/usb/core/hub.c'>
<input type='hidden' name='id' value='b17c1bba9cec1727451b906d9a0c209774624873'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?id=b17c1bba9cec1727451b906d9a0c209774624873'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers?id=b17c1bba9cec1727451b906d9a0c209774624873'>drivers</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb?id=b17c1bba9cec1727451b906d9a0c209774624873'>usb</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/core?id=b17c1bba9cec1727451b906d9a0c209774624873'>core</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>hub.c</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='id' value='b17c1bba9cec1727451b906d9a0c209774624873'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Rui Miguel Silva <rmfrfs@gmail.com></td><td class='right'>2017-01-23 16:32:57 +0000</td></tr>
<tr><th>committer</th><td>Greg Kroah-Hartman <gregkh@linuxfoundation.org></td><td class='right'>2017-01-25 11:36:59 +0100</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>b17c1bba9cec1727451b906d9a0c209774624873</a> (<a href='/cgit.cgi/linux/net-next.git/patch/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?id=b17c1bba9cec1727451b906d9a0c209774624873'>f0a0f51d405c884e23f695695858d85f6260fec0</a> /<a href='/cgit.cgi/linux/net-next.git/tree/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873'>drivers/usb/core/hub.c</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/core/hub.c?id=9579c4dc21292f375715d7acca439dac9855b3e9'>9579c4dc21292f375715d7acca439dac9855b3e9</a> (<a href='/cgit.cgi/linux/net-next.git/diff/drivers/usb/core/hub.c?id=b17c1bba9cec1727451b906d9a0c209774624873&id2=9579c4dc21292f375715d7acca439dac9855b3e9'>diff</a>)</td></tr></table>
<div class='commit-subject'>staging: greybus: timesync: validate platform state callback</div><div class='commit-msg'>When tearingdown timesync, and not in arche platform, the state platform
callback is not initialized. That will trigger the following NULL
dereferencing.
CallTrace:
? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus]
gb_timesync_teardown+0x85/0xc0 [greybus]
gb_timesync_svc_remove+0xab/0x190 [greybus]
gb_svc_del+0x29/0x110 [greybus]
gb_hd_del+0x14/0x20 [greybus]
ap_disconnect+0x24/0x60 [gb_es2]
usb_unbind_interface+0x7a/0x2c0
__device_release_driver+0x96/0x150
device_release_driver+0x1e/0x30
bus_remove_device+0xe7/0x130
device_del+0x116/0x230
usb_disable_device+0x97/0x1f0
usb_disconnect+0x80/0x260
hub_event+0x5ca/0x10e0
process_one_work+0x126/0x3b0
worker_thread+0x55/0x4c0
? process_one_work+0x3b0/0x3b0
kthread+0xc4/0xe0
? kthread_park+0xb0/0xb0
ret_from_fork+0x22/0x30
So, fix that by adding checks before use the callback.
Fixes: 970dc85bd95d ("greybus: timesync: Add timesync core driver")
Cc: <stable@vger.kernel.org> # 4.9.x
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?id=b17c1bba9cec1727451b906d9a0c209774624873'>Diffstat</a> (limited to 'drivers/usb/core/hub.c')</div><table summary='diffstat' class='diffstat'>