63a25c3907bed16a2e9d18b115d1fd Mon Sep 17 00:00:00 2001
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 6 Feb 2017 15:55:23 -0800
Subject: net: dsa: Do not clobber PHY link outside of state machine

Calling phy_read_status() means that we may call into
genphy_read_status() which in turn will use genphy_update_link() which
can make changes to phydev->link outside of the state machine's state
transitions. This is an invalid behavior that is now caught as of
811a919135b9 ("phy state machine: failsafe leave invalid RUNNING state")

Reported-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/dsa/slave.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

(limited to 'net/dsa')

t.cgi/'>index</a> : <a href='/cgit.cgi/linux/net-next.git/'>net-next.git</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'/><select name='h' onchange='this.form.submit();'>
<option value='emaclite-cleanup'>emaclite-cleanup</option>
<option value='master'>master</option>
<option value='nds-private-remove' selected='selected'>nds-private-remove</option>
<option value='packet-loop-back'>packet-loop-back</option>
<option value='packet-rx-pump-back'>packet-rx-pump-back</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/?h=nds-private-remove'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>refs</a><a class='active' href='/cgit.cgi/linux/net-next.git/log/drivers/usb/phy/phy-generic.h?h=nds-private-remove'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/drivers/usb/phy/phy-generic.h?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>tree</a><a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/phy/phy-generic.h?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/drivers/usb/phy/phy-generic.h?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/drivers/usb/phy/phy-generic.h'>
<input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/log/?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>root</a>/<a href='/cgit.cgi/linux/net-next.git/log/drivers?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>drivers</a>/<a href='/cgit.cgi/linux/net-next.git/log/drivers/usb?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>usb</a>/<a href='/cgit.cgi/linux/net-next.git/log/drivers/usb/phy?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>phy</a>/<a href='/cgit.cgi/linux/net-next.git/log/drivers/usb/phy/phy-generic.h?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60'>phy-generic.h</a></div><div class='content'><table class='list nowrap'><tr class='nohover'><th class='left'>Age</th><th class='left'>Commit message (<a href='/cgit.cgi/linux/net-next.git/log/drivers/usb/phy/phy-generic.h?h=nds-private-remove&amp;id=bfb34527a32a1a576d9bfb7026d3ab0369a6cd60&amp;showmsg=1'>Expand</a>)</th><th class='left'>Author</th><th class='left'>Files</th><th class='left'>Lines</th></tr>