et-next plumbings</title>
<meta name='generator' content='cgit v1.2.3-54-g00ecf'/>
<meta name='robots' content='noindex, nofollow'/>
<link rel='stylesheet' type='text/css' href='/cgit.css'/>
<script type='text/javascript' src='/cgit.js'></script>
<link rel='shortcut icon' href='http://distanz.ch/favicon.ico'/>
<link rel='alternate' title='Atom feed' href='https://git.distanz.ch/cgit.cgi/linux/net-next.git/atom/drivers/usb/host/uhci-debug.c?h=master' type='application/atom+xml'/>
<link rel='vcs-git' href='git://git.distanz.ch/linux/net-next.git' title='net-next.git Git repository'/>
<link rel='vcs-git' href='http:///git.distanz.ch/cgit.cgi/linux/net-next.git' title='net-next.git Git repository'/>
</head>
<body>
<div id='cgit'><table id='header'>
<tr>
<td class='logo' rowspan='2'><a href='/cgit.cgi/'><img src='/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/cgit.cgi/'>index</a> : <a href='/cgit.cgi/linux/net-next.git/'>net-next.git</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='08d85f3ea99f1eeafc4e8507936190e86a16ee8c'/><select name='h' onchange='this.form.submit();'>
<option value='emaclite-cleanup'>emaclite-cleanup</option>
<option value='master' selected='selected'>master</option>
<option value='nds-private-remove'>nds-private-remove</option>
<option value='packet-loop-back'>packet-loop-back</option>
<option value='packet-rx-pump-back'>packet-rx-pump-back</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/drivers/usb/host/uhci-debug.c'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/drivers/usb/host/uhci-debug.c'>
<input type='hidden' name='id' value='08d85f3ea99f1eeafc4e8507936190e86a16ee8c'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>drivers</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>usb</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/host?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>host</a>/<a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>uhci-debug.c</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='id' value='08d85f3ea99f1eeafc4e8507936190e86a16ee8c'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Marc Zyngier &lt;marc.zyngier@arm.com&gt;</td><td class='right'>2017-01-17 16:00:48 +0000</td></tr>
<tr><th>committer</th><td>Thomas Gleixner &lt;tglx@linutronix.de&gt;</td><td class='right'>2017-01-30 15:18:56 +0100</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>08d85f3ea99f1eeafc4e8507936190e86a16ee8c</a> (<a href='/cgit.cgi/linux/net-next.git/patch/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>410bb1acd0cd7dcfaad37ae7b63ff243b7fa4bee</a> /<a href='/cgit.cgi/linux/net-next.git/tree/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>drivers/usb/host/uhci-debug.c</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/drivers/usb/host/uhci-debug.c?id=566cf877a1fcb6d6dc0126b076aad062054c2637'>566cf877a1fcb6d6dc0126b076aad062054c2637</a> (<a href='/cgit.cgi/linux/net-next.git/diff/drivers/usb/host/uhci-debug.c?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c&amp;id2=566cf877a1fcb6d6dc0126b076aad062054c2637'>diff</a>)</td></tr></table>
<div class='commit-subject'>irqdomain: Avoid activating interrupts more than once</div><div class='commit-msg'>Since commit f3b0946d629c ("genirq/msi: Make sure PCI MSIs are
activated early"), we can end-up activating a PCI/MSI twice (once
at allocation time, and once at startup time).

This is normally of no consequences, except that there is some
HW out there that may misbehave if activate is used more than once
(the GICv3 ITS, for example, uses the activate callback
to issue the MAPVI command, and the architecture spec says that
"If there is an existing mapping for the EventID-DeviceID
combination, behavior is UNPREDICTABLE").

While this could be worked around in each individual driver, it may
make more sense to tackle the issue at the core level. In order to
avoid getting in that situation, let's have a per-interrupt flag
to remember if we have already activated that interrupt or not.

Fixes: f3b0946d629c ("genirq/msi: Make sure PCI MSIs are activated early")
Reported-and-tested-by: Andre Przywara &lt;andre.przywara@arm.com&gt;
Signed-off-by: Marc Zyngier &lt;marc.zyngier@arm.com&gt;
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/1484668848-24361-1-git-send-email-marc.zyngier@arm.com
Signed-off-by: Thomas Gleixner &lt;tglx@linutronix.de&gt;

</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?id=08d85f3ea99f1eeafc4e8507936190e86a16ee8c'>Diffstat</a> (limited to 'drivers/usb/host/uhci-debug.c')</div><table summary='diffstat' class='diffstat'>