ext.git - net-next plumbings</title>
<meta name='generator' content='cgit v1.2.3-54-g00ecf'/>
<meta name='robots' content='noindex, nofollow'/>
<link rel='stylesheet' type='text/css' href='/cgit.css'/>
<script type='text/javascript' src='/cgit.js'></script>
<link rel='shortcut icon' href='http://distanz.ch/favicon.ico'/>
<link rel='alternate' title='Atom feed' href='https://git.distanz.ch/cgit.cgi/linux/net-next.git/atom/include/uapi/xen?h=nds-private-remove' type='application/atom+xml'/>
<link rel='vcs-git' href='git://git.distanz.ch/linux/net-next.git' title='net-next.git Git repository'/>
<link rel='vcs-git' href='http:///git.distanz.ch/cgit.cgi/linux/net-next.git' title='net-next.git Git repository'/>
</head>
<body>
<div id='cgit'><table id='header'>
<tr>
<td class='logo' rowspan='2'><a href='/cgit.cgi/'><img src='/cgit.png' alt='cgit logo'/></a></td>
<td class='main'><a href='/cgit.cgi/'>index</a> : <a href='/cgit.cgi/linux/net-next.git/'>net-next.git</a></td><td class='form'><form method='get'>
<input type='hidden' name='id' value='ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'/><select name='h' onchange='this.form.submit();'>
<option value='emaclite-cleanup'>emaclite-cleanup</option>
<option value='master'>master</option>
<option value='nds-private-remove' selected='selected'>nds-private-remove</option>
<option value='packet-loop-back'>packet-loop-back</option>
<option value='packet-rx-pump-back'>packet-rx-pump-back</option>
</select> <input type='submit' value='switch'/></form></td></tr>
<tr><td class='sub'>net-next plumbings</td><td class='sub right'>Tobias Klauser</td></tr></table>
<table class='tabs'><tr><td>
<a href='/cgit.cgi/linux/net-next.git/?h=nds-private-remove'>summary</a><a href='/cgit.cgi/linux/net-next.git/refs/?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>refs</a><a href='/cgit.cgi/linux/net-next.git/log/include/uapi/xen?h=nds-private-remove'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/include/uapi/xen'>
<input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/include?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>include</a>/<a href='/cgit.cgi/linux/net-next.git/commit/include/uapi?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>uapi</a>/<a href='/cgit.cgi/linux/net-next.git/commit/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>xen</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Tony Lindgren &lt;tony@atomide.com&gt;</td><td class='right'>2017-01-19 08:49:07 -0800</td></tr>
<tr><th>committer</th><td>Vinod Koul &lt;vinod.koul@intel.com&gt;</td><td class='right'>2017-01-25 11:29:11 +0530</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b</a> (<a href='/cgit.cgi/linux/net-next.git/patch/include/uapi/xen?id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>139fc7e29f97d6bb6c4dca2a97be2dc3f824bd51</a> /<a href='/cgit.cgi/linux/net-next.git/tree/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>include/uapi/xen</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/include/uapi/xen?h=nds-private-remove&amp;id=49def1853334396f948dcb4cedb9347abb318df5'>49def1853334396f948dcb4cedb9347abb318df5</a> (<a href='/cgit.cgi/linux/net-next.git/diff/include/uapi/xen?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b&amp;id2=49def1853334396f948dcb4cedb9347abb318df5'>diff</a>)</td></tr></table>
<div class='commit-subject'>dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage</div><div class='commit-msg'>Commit fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")
added runtime PM support for cppi41, but had corner case issues. Some of
the issues were fixed with commit 098de42ad670 ("dmaengine: cppi41: Fix
unpaired pm runtime when only a USB hub is connected"). That fix however
caused a new regression where we can get error -115 messages with USB on
BeagleBone when connecting a USB mass storage device to a hub.

This is because when connecting a USB mass storage device to a hub, the
initial DMA transfers can take over 200ms to complete and cppi41
autosuspend delay times out.

To fix the issue, we want to implement refcounting for chan_busy array
that contains the active dma transfers. Increasing the autosuspend delay
won't help as that the delay could be potentially seconds, and it's best
to let the USB subsystem to deal with the timeouts on errors.

The earlier attempt for runtime PM was buggy as the pm_runtime_get/put()
calls could get unpaired easily as they did not follow the state of
the chan_busy array as described in commit 098de42ad670 ("dmaengine:
cppi41: Fix unpaired pm runtime when only a USB hub is connected".

Let's fix the issue by adding pm_runtime_get() to where a new transfer
is added to the chan_busy array, and calls to pm_runtime_put() where
chan_busy array entry is cleared. This prevents any autosuspend timeouts
from happening while dma transfers are active.

Fixes: 098de42ad670 ("dmaengine: cppi41: Fix unpaired pm runtime when
only a USB hub is connected")
Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support")
Cc: Andy Shevchenko &lt;andy.shevchenko@gmail.com&gt;
Cc: Bin Liu &lt;b-liu@ti.com&gt;
Cc: Grygorii Strashko &lt;grygorii.strashko@ti.com&gt;
Cc: Kevin Hilman &lt;khilman@baylibre.com&gt;
Cc: Patrick Titiano &lt;ptitiano@baylibre.com&gt;
Cc: Sergei Shtylyov &lt;sergei.shtylyov@cogentembedded.com&gt;
Signed-off-by: Tony Lindgren &lt;tony@atomide.com&gt;
Tested-by: Bin Liu &lt;b-liu@ti.com&gt;
Signed-off-by: Vinod Koul &lt;vinod.koul@intel.com&gt;
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=ae4a3e028bb8b59e7cfeb0cc9ef03d885182ce8b'>Diffstat</a> (limited to 'include/uapi/xen')</div><table summary='diffstat' class='diffstat'>