diff options

author	Vincent <vincent.stehle@laposte.net>	2017-01-30 15:06:43 +0100
committer	David S. Miller <davem@davemloft.net>	2017-01-31 13:07:40 -0500
commit	c73e44269369e936165f0f9b61f1f09a11dae01c (patch)
tree	e2188e900ba06302f8ed2746cb07edd3efbc5c35 /fs/nfs/nfstrace.c
parent	040587af31228d82c52267f717c9fcdb65f36335 (diff)

net: thunderx: avoid dereferencing xcv when NULL

This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Sunil Goutham <sgoutham@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>

Diffstat (limited to 'fs/nfs/nfstrace.c')

v4 [1] More importantly, Florian opposed adding a DT property mapping a device register this directly [2]. The concern was that the property could be abused to implement platform configuration policy. After discussing it, I think we agreed that such information about the HW (defect) should appear in the platform DT. However, the preferred way is to add a boolean property for each EEE broken mode. [0]: http://lkml.kernel.org/r/1480326409-25419-1-git-send-email-jbrunet@baylibre.com [1]: http://lkml.kernel.org/r/1480348229-25672-1-git-send-email-jbrunet@baylibre.com [2]: http://lkml.kernel.org/r/e14a3b0c-dc34-be14-48b3-518a0ad0c080@gmail.com ==================== Signed-off-by: David S. Miller <davem@davemloft.net>

Diffstat (limited to 'include')


context:
space:
mode: