diff options
author | Johan Hovold <johan@kernel.org> | 2017-01-03 16:39:51 +0100 |
---|---|---|
committer | Johan Hovold <johan@kernel.org> | 2017-01-04 10:37:19 +0100 |
commit | 91a1ff4d53c5184d383d0baeeaeab6f9736f2ff3 (patch) | |
tree | 4fabca34fe651a453109b93a970be6cc96432f18 | |
parent | b05aebc25fdc5aeeac3ee29f0dc9f58dd07c13cc (diff) |
USB: serial: mos7720: fix use-after-free on probe errors
The interrupt URB was submitted on probe but never stopped on probe
errors. This can lead to use-after-free issues in the completion
handler when accessing the freed usb-serial struct:
Unable to handle kernel paging request at virtual address 6b6b6be7
...
[<bf052e70>] (mos7715_interrupt_callback [mos7720]) from [<c052a894>] (__usb_hcd_giveback_urb+0x80/0x140)
[<c052a894>] (__usb_hcd_giveback_urb) from [<c052a9a4>] (usb_hcd_giveback_urb+0x50/0x138)
[<c052a9a4>] (usb_hcd_giveback_urb) from [<c0550684>] (musb_giveback+0xc8/0x1cc)
Fixes: b69578df7e98 ("USB: usbserial: mos7720: add support for parallel
port on moschip 7715")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>