/* * Copyright (C) 2014 Freescale Semiconductor, Inc. * * Author: Jun Li * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #ifndef __DRIVERS_USB_CHIPIDEA_OTG_FSM_H #define __DRIVERS_USB_CHIPIDEA_OTG_FSM_H #include /* * A-DEVICE timing constants */ /* Wait for VBUS Rise */ #define TA_WAIT_VRISE (100) /* a_wait_vrise: section 7.1.2 * a_wait_vrise_tmr: section 7.4.5.1 * TA_VBUS_RISE <= 100ms, section 4.4 * Table 4-1: Electrical Characteristics * ->DC Electrical Timing */ /* Wait for VBUS Fall */ #define TA_WAIT_VFALL (1000) /* a_wait_vfall: section 7.1.7 * a_wait_vfall_tmr: section: 7.4.5.2 */ /* Wait for B-Connect */ #define TA_WAIT_BCON (10000) /* a_wait_bcon: section 7.1.3 * TA_WAIT_BCON: should be between 1100 * and 30000 ms, section 5.5, Table 5-1 */ /* A-Idle to B-Disconnect */ #define TA_AIDL_BDIS (5000) /* a_suspend min 200 ms, section 5.2.1 * TA_AIDL_BDIS: section 5.5, Table 5-1 */ /* B-Idle to A-Disconnect */ #define TA_BIDL_ADIS (500) /* TA_BIDL_ADIS: section 5.2.1 * 500ms is used for B switch to host * for safe */ /* * B-device timing constants */ /* Data-Line Pulse Time*/ #define TB_DATA_PLS (10) /* b_srp_init,continue 5~10ms * section:5.1.3 */ /* SRP Fail Time */ #define TB_SRP_FAIL (6000) /* b_srp_init,fail time 5~6s * section:5.1.6 */ /* A-SE0 to B-Reset */ #define TB_ASE0_BRST (155) /* minimum 155 ms, section:5.3.1 */ /* SE0 Time Before SRP */ #define TB_SE0_SRP (1000) /* b_idle,minimum 1s, section:5.1.2 */ /* SSEND time before SRP */ #define TB_SSEND_SRP (1500) /* minimum 1.5 sec, section:5.1.2 */ #define TB_AIDL_BDIS (20) /* 4ms ~ 150ms, section 5.2.1 */ #if IS_ENABLED(CONFIG_USB_OTG_FSM) int ci_hdrc_otg_fsm_init(struct ci_hdrc *ci); int ci_otg_fsm_work(struct ci_hdrc *ci); irqreturn_t ci_otg_fsm_irq(struct ci_hdrc *ci); void ci_hdrc_otg_fsm_start(struct ci_hdrc *ci); void ci_hdrc_otg_fsm_remove(struct ci_hdrc *ci); #else static inline int ci_hdrc_otg_fsm_init(struct ci_hdrc *ci) { return 0; } static inline int ci_otg_fsm_work(struct ci_hdrc *ci) { return -ENXIO; } static inline irqreturn_t ci_otg_fsm_irq(struct ci_hdrc *ci) { return IRQ_NONE; } static inline void ci_hdrc_otg_fsm_start(struct ci_hdrc *ci) { } static inline void ci_hdrc_otg_fsm_remove(struct ci_hdrc *ci) { } #endif #endif /* __DRIVERS_USB_CHIPIDEA_OTG_FSM_H */ r>
path: root/net/irda/irnet/irnet_ppp.h
diff options
context:
space:
mode:
authorDouglas Miller <dougmill@linux.vnet.ibm.com>2017-01-28 06:42:20 -0600
committerTejun Heo <tj@kernel.org>2017-01-28 07:49:42 -0500
commit966d2b04e070bc040319aaebfec09e0144dc3341 (patch)
tree4b96156e3d1dd4dfd6039b7c219c9dc4616da52d /net/irda/irnet/irnet_ppp.h
parent1b1bc42c1692e9b62756323c675a44cb1a1f9dbd (diff)
percpu-refcount: fix reference leak during percpu-atomic transition
percpu_ref_tryget() and percpu_ref_tryget_live() should return "true" IFF they acquire a reference. But the return value from atomic_long_inc_not_zero() is a long and may have high bits set, e.g. PERCPU_COUNT_BIAS, and the return value of the tryget routines is bool so the reference may actually be acquired but the routines return "false" which results in a reference leak since the caller assumes it does not need to do a corresponding percpu_ref_put(). This was seen when performing CPU hotplug during I/O, as hangs in blk_mq_freeze_queue_wait where percpu_ref_kill (blk_mq_freeze_queue_start) raced with percpu_ref_tryget (blk_mq_timeout_work). Sample stack trace: __switch_to+0x2c0/0x450 __schedule+0x2f8/0x970 schedule+0x48/0xc0 blk_mq_freeze_queue_wait+0x94/0x120 blk_mq_queue_reinit_work+0xb8/0x180 blk_mq_queue_reinit_prepare+0x84/0xa0 cpuhp_invoke_callback+0x17c/0x600 cpuhp_up_callbacks+0x58/0x150 _cpu_up+0xf0/0x1c0 do_cpu_up+0x120/0x150 cpu_subsys_online+0x64/0xe0 device_online+0xb4/0x120 online_store+0xb4/0xc0 dev_attr_store+0x68/0xa0 sysfs_kf_write+0x80/0xb0 kernfs_fop_write+0x17c/0x250 __vfs_write+0x6c/0x1e0 vfs_write+0xd0/0x270 SyS_write+0x6c/0x110 system_call+0x38/0xe0 Examination of the queue showed a single reference (no PERCPU_COUNT_BIAS, and __PERCPU_REF_DEAD, __PERCPU_REF_ATOMIC set) and no requests. However, conditions at the time of the race are count of PERCPU_COUNT_BIAS + 0 and __PERCPU_REF_DEAD and __PERCPU_REF_ATOMIC set. The fix is to make the tryget routines use an actual boolean internally instead of the atomic long result truncated to a int. Fixes: e625305b3907 percpu-refcount: make percpu_ref based on longs instead of ints Link: https://bugzilla.kernel.org/show_bug.cgi?id=190751 Signed-off-by: Douglas Miller <dougmill@linux.vnet.ibm.com> Reviewed-by: Jens Axboe <axboe@fb.com> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: e625305b3907 ("percpu-refcount: make percpu_ref based on longs instead of ints") Cc: stable@vger.kernel.org # v3.18+
Diffstat (limited to 'net/irda/irnet/irnet_ppp.h')