/** * dwc3-of-simple.c - OF glue layer for simple integrations * * Copyright (c) 2015 Texas Instruments Incorporated - http://www.ti.com * * Author: Felipe Balbi * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 of * the License as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * This is a combination of the old dwc3-qcom.c by Ivan T. Ivanov * and the original patch adding support for Xilinx' SoC * by Subbaraya Sundeep Bhatta */ #include #include #include #include #include #include #include #include #include #include struct dwc3_of_simple { struct device *dev; struct clk **clks; int num_clocks; }; static int dwc3_of_simple_clk_init(struct dwc3_of_simple *simple, int count) { struct device *dev = simple->dev; struct device_node *np = dev->of_node; int i; simple->num_clocks = count; if (!count) return 0; simple->clks = devm_kcalloc(dev, simple->num_clocks, sizeof(struct clk *), GFP_KERNEL); if (!simple->clks) return -ENOMEM; for (i = 0; i < simple->num_clocks; i++) { struct clk *clk; int ret; clk = of_clk_get(np, i); if (IS_ERR(clk)) { while (--i >= 0) clk_put(simple->clks[i]); return PTR_ERR(clk); } ret = clk_prepare_enable(clk); if (ret < 0) { while (--i >= 0) { clk_disable_unprepare(simple->clks[i]); clk_put(simple->clks[i]); } clk_put(clk); return ret; } simple->clks[i] = clk; } return 0; } static int dwc3_of_simple_probe(struct platform_device *pdev) { struct dwc3_of_simple *simple; struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; int ret; int i; simple = devm_kzalloc(dev, sizeof(*simple), GFP_KERNEL); if (!simple) return -ENOMEM; platform_set_drvdata(pdev, simple); simple->dev = dev; ret = dwc3_of_simple_clk_init(simple, of_clk_get_parent_count(np)); if (ret) return ret; ret = of_platform_populate(np, NULL, NULL, dev); if (ret) { for (i = 0; i < simple->num_clocks; i++) { clk_disable_unprepare(simple->clks[i]); clk_put(simple->clks[i]); } return ret; } pm_runtime_set_active(dev); pm_runtime_enable(dev); pm_runtime_get_sync(dev); return 0; } static int dwc3_of_simple_remove(struct platform_device *pdev) { struct dwc3_of_simple *simple = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; int i; for (i = 0; i < simple->num_clocks; i++) { clk_disable_unprepare(simple->clks[i]); clk_put(simple->clks[i]); } of_platform_depopulate(dev); pm_runtime_put_sync(dev); pm_runtime_disable(dev); return 0; } #ifdef CONFIG_PM static int dwc3_of_simple_runtime_suspend(struct device *dev) { struct dwc3_of_simple *simple = dev_get_drvdata(dev); int i; for (i = 0; i < simple->num_clocks; i++) clk_disable(simple->clks[i]); return 0; } static int dwc3_of_simple_runtime_resume(struct device *dev) { struct dwc3_of_simple *simple = dev_get_drvdata(dev); int ret; int i; for (i = 0; i < simple->num_clocks; i++) { ret = clk_enable(simple->clks[i]); if (ret < 0) { while (--i >= 0) clk_disable(simple->clks[i]); return ret; } } return 0; } #endif static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = { SET_RUNTIME_PM_OPS(dwc3_of_simple_runtime_suspend, dwc3_of_simple_runtime_resume, NULL) }; static const struct of_device_id of_dwc3_simple_match[] = { { .compatible = "qcom,dwc3" }, { .compatible = "rockchip,rk3399-dwc3" }, { .compatible = "xlnx,zynqmp-dwc3" }, { .compatible = "cavium,octeon-7130-usb-uctl" }, { /* Sentinel */ } }; MODULE_DEVICE_TABLE(of, of_dwc3_simple_match); static struct platform_driver dwc3_of_simple_driver = { .probe = dwc3_of_simple_probe, .remove = dwc3_of_simple_remove, .driver = { .name = "dwc3-of-simple", .of_match_table = of_dwc3_simple_match, }, }; module_platform_driver(dwc3_of_simple_driver); MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("DesignWare USB3 OF Simple Glue Layer"); MODULE_AUTHOR("Felipe Balbi "); e2d5527ab2b5ff46158012678289b16 parentf4fad34c0e45b3e30d2b5312d545e2d416778c7b (diff)
qede: Revise state locking scheme
As qede utilizes an internal-reload sequence as result of various configuration changes, the netif state wouldn't always accurately describe the status of the configuration. To compensate, we're storing an internal state of the device, which should only be accessed under the qede_lock. This patch fixes and improves several state/lock interactions: - The internal state should only be checked while locked. - While holding lock, it's preferable to check state rather than the netdevice's state. - The reload sequence is not 'atomic' - unload and subsequent load are not in the same critical section. This also add the 'locked' variant for the reload, which would later be used by XDP - useful in the case where the correct sequence is 'lock, check state and re-configure if good', instead of allowing the reload itself to make the decision regarding the configurability of the device. Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat