/** * ulpi.c - DesignWare USB3 Controller's ULPI PHY interface * * Copyright (C) 2015 Intel Corporation * * Author: Heikki Krogerus * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #include #include "core.h" #include "io.h" #define DWC3_ULPI_ADDR(a) \ ((a >= ULPI_EXT_VENDOR_SPECIFIC) ? \ DWC3_GUSB2PHYACC_ADDR(ULPI_ACCESS_EXTENDED) | \ DWC3_GUSB2PHYACC_EXTEND_ADDR(a) : DWC3_GUSB2PHYACC_ADDR(a)) static int dwc3_ulpi_busyloop(struct dwc3 *dwc) { unsigned count = 1000; u32 reg; while (count--) { reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYACC(0)); if (!(reg & DWC3_GUSB2PHYACC_BUSY)) return 0; cpu_relax(); } return -ETIMEDOUT; } static int dwc3_ulpi_read(struct device *dev, u8 addr) { struct dwc3 *dwc = dev_get_drvdata(dev); u32 reg; int ret; reg = DWC3_GUSB2PHYACC_NEWREGREQ | DWC3_ULPI_ADDR(addr); dwc3_writel(dwc->regs, DWC3_GUSB2PHYACC(0), reg); ret = dwc3_ulpi_busyloop(dwc); if (ret) return ret; reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYACC(0)); return DWC3_GUSB2PHYACC_DATA(reg); } static int dwc3_ulpi_write(struct device *dev, u8 addr, u8 val) { struct dwc3 *dwc = dev_get_drvdata(dev); u32 reg; reg = DWC3_GUSB2PHYACC_NEWREGREQ | DWC3_ULPI_ADDR(addr); reg |= DWC3_GUSB2PHYACC_WRITE | val; dwc3_writel(dwc->regs, DWC3_GUSB2PHYACC(0), reg); return dwc3_ulpi_busyloop(dwc); } static const struct ulpi_ops dwc3_ulpi_ops = { .read = dwc3_ulpi_read, .write = dwc3_ulpi_write, }; int dwc3_ulpi_init(struct dwc3 *dwc) { /* Register the interface */ dwc->ulpi = ulpi_register_interface(dwc->dev, &dwc3_ulpi_ops); if (IS_ERR(dwc->ulpi)) { dev_err(dwc->dev, "failed to register ULPI interface"); return PTR_ERR(dwc->ulpi); } return 0; } void dwc3_ulpi_exit(struct dwc3 *dwc) { if (dwc->ulpi) { ulpi_unregister_interface(dwc->ulpi); dwc->ulpi = NULL; } } ive' href='/cgit.cgi/linux/net-next.git/commit/sound/pci/trident/Makefile?h=nds-private-remove&id=b98acbff9a05b371c5f0ca6e44a3af8ce9274379'>commitdiff
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-01-11 15:36:20 +0000
committerMark Brown <broonie@kernel.org>2017-01-18 16:32:44 +0000
commitb98acbff9a05b371c5f0ca6e44a3af8ce9274379 (patch)
treed6835885f859a456e62ce93621041138d6a54f9b /sound/pci/trident/Makefile
parentd00b74613fb18dfd0a5aa99270ee2e72d5c808d7 (diff)
regulator: twl6030: fix range comparison, allowing vsel = 59
The range min_uV > 1350000 && min_uV <= 150000 is never reachable because of a typo in the previous range check and hence vsel = 59 is never reached. Fix the previous range check to enable the vsel = 59 setting. Fixes CoverityScan CID#728454 ("Logially dead code") Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/pci/trident/Makefile')