/* * Copyright (C) 2014 Marvell * Author: Gregory CLEMENT * * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License * version 2 as published by the Free Software Foundation. */ #include #include #include #include #include #include #include "xhci-mvebu.h" #define USB3_MAX_WINDOWS 4 #define USB3_WIN_CTRL(w) (0x0 + ((w) * 8)) #define USB3_WIN_BASE(w) (0x4 + ((w) * 8)) static void xhci_mvebu_mbus_config(void __iomem *base, const struct mbus_dram_target_info *dram) { int win; /* Clear all existing windows */ for (win = 0; win < USB3_MAX_WINDOWS; win++) { writel(0, base + USB3_WIN_CTRL(win)); writel(0, base + USB3_WIN_BASE(win)); } /* Program each DRAM CS in a seperate window */ for (win = 0; win < dram->num_cs; win++) { const struct mbus_dram_window *cs = dram->cs + win; writel(((cs->size - 1) & 0xffff0000) | (cs->mbus_attr << 8) | (dram->mbus_dram_target_id << 4) | 1, base + USB3_WIN_CTRL(win)); writel((cs->base & 0xffff0000), base + USB3_WIN_BASE(win)); } } int xhci_mvebu_mbus_init_quirk(struct usb_hcd *hcd) { struct device *dev = hcd->self.controller; struct platform_device *pdev = to_platform_device(dev); struct resource *res; void __iomem *base; const struct mbus_dram_target_info *dram; res = platform_get_resource(pdev, IORESOURCE_MEM, 1); if (!res) return -ENODEV; /* * We don't use devm_ioremap() because this mapping should * only exists for the duration of this probe function. */ base = ioremap(res->start, resource_size(res)); if (!base) return -ENODEV; dram = mv_mbus_dram_info(); xhci_mvebu_mbus_config(base, dram); /* * This memory area was only needed to configure the MBus * windows, and is therefore no longer useful. */ iounmap(base); return 0; } 1d6feb4a'>treecommitdiff
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
committerTejun Heo <tj@kernel.org>2017-01-26 16:47:28 -0500
commit07cd12945551b63ecb1a349d50a6d69d1d6feb4a (patch)
tree75f65eba7eac9277971082a2d5a4cf1370562c0c /include/rdma/ib_cm.h
parent7ce7d89f48834cefece7804d38fc5d85382edf77 (diff)
cgroup: don't online subsystems before cgroup_name/path() are operational
While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems before the new cgroup is associated with it kernfs_node. This is fine for cgroup proper but cgroup_name/path() depend on the associated kernfs_node and if a subsystem makes the new cgroup_subsys_state visible, which they're allowed to after onlining, it can lead to NULL dereference. The current code performs cgroup creation and subsystem onlining in cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems visible afterwards. There's no reason to online the subsystems early and we can simply drop cgroup_apply_control_enable() call from cgroup_create() so that the subsystems are onlined and made visible at the same time. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru> Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") Cc: stable@vger.kernel.org # v4.6+
Diffstat (limited to 'include/rdma/ib_cm.h')