/* Copyright (C) 2005-2006 by Texas Instruments */ #ifndef _CPPI_DMA_H_ #define _CPPI_DMA_H_ #include #include #include #include #include #include "musb_core.h" #include "musb_dma.h" /* CPPI RX/TX state RAM */ struct cppi_tx_stateram { u32 tx_head; /* "DMA packet" head descriptor */ u32 tx_buf; u32 tx_current; /* current descriptor */ u32 tx_buf_current; u32 tx_info; /* flags, remaining buflen */ u32 tx_rem_len; u32 tx_dummy; /* unused */ u32 tx_complete; }; struct cppi_rx_stateram { u32 rx_skipbytes; u32 rx_head; u32 rx_sop; /* "DMA packet" head descriptor */ u32 rx_current; /* current descriptor */ u32 rx_buf_current; u32 rx_len_len; u32 rx_cnt_cnt; u32 rx_complete; }; /* hw_options bits in CPPI buffer descriptors */ #define CPPI_SOP_SET ((u32)(1 << 31)) #define CPPI_EOP_SET ((u32)(1 << 30)) #define CPPI_OWN_SET ((u32)(1 << 29)) /* owned by cppi */ #define CPPI_EOQ_MASK ((u32)(1 << 28)) #define CPPI_ZERO_SET ((u32)(1 << 23)) /* rx saw zlp; tx issues one */ #define CPPI_RXABT_MASK ((u32)(1 << 19)) /* need more rx buffers */ #define CPPI_RECV_PKTLEN_MASK 0xFFFF #define CPPI_BUFFER_LEN_MASK 0xFFFF #define CPPI_TEAR_READY ((u32)(1 << 31)) /* CPPI data structure definitions */ #define CPPI_DESCRIPTOR_ALIGN 16 /* bytes; 5-dec docs say 4-byte align */ struct cppi_descriptor { /* hardware overlay */ u32 hw_next; /* next buffer descriptor Pointer */ u32 hw_bufp; /* i/o buffer pointer */ u32 hw_off_len; /* buffer_offset16, buffer_length16 */ u32 hw_options; /* flags: SOP, EOP etc*/ struct cppi_descriptor *next; dma_addr_t dma; /* address of this descriptor */ u32 buflen; /* for RX: original buffer length */ } __attribute__ ((aligned(CPPI_DESCRIPTOR_ALIGN))); struct cppi; /* CPPI Channel Control structure */ struct cppi_channel { struct dma_channel channel; /* back pointer to the DMA controller structure */ struct cppi *controller; /* which direction of which endpoint? */ struct musb_hw_ep *hw_ep; bool transmit; u8 index; /* DMA modes: RNDIS or "transparent" */ u8 is_rndis; /* book keeping for current transfer request */ dma_addr_t buf_dma; u32 buf_len; u32 maxpacket; u32 offset; /* dma requested */ void __iomem *state_ram; /* CPPI state */ struct cppi_descriptor *freelist; /* BD management fields */ struct cppi_descriptor *head; struct cppi_descriptor *tail; struct cppi_descriptor *last_processed; /* use tx_complete in host role to track endpoints waiting for * FIFONOTEMPTY to clear. */ struct list_head tx_complete; }; /* CPPI DMA controller object */ struct cppi { struct dma_controller controller; struct musb *musb; void __iomem *mregs; /* Mentor regs */ void __iomem *tibase; /* TI/CPPI regs */ int irq; struct cppi_channel tx[4]; struct cppi_channel rx[4]; struct dma_pool *pool; struct list_head tx_complete; }; /* CPPI IRQ handler */ extern irqreturn_t cppi_interrupt(int, void *); struct cppi41_dma_channel { struct dma_channel channel; struct cppi41_dma_controller *controller; struct musb_hw_ep *hw_ep; struct dma_chan *dc; dma_cookie_t cookie; u8 port_num; u8 is_tx; u8 is_allocated; u8 usb_toggle; dma_addr_t buf_addr; u32 total_len; u32 prog_len; u32 transferred; u32 packet_sz; struct list_head tx_check; int tx_zlp; }; #endif /* end of ifndef _CPPI_DMA_H_ */ ption>space:mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /fs/autofs4/Makefile
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/autofs4/Makefile')