/* * Copyright (C) 2005-2006 by Texas Instruments * * The Inventra Controller Driver for Linux is free software; you * can redistribute it and/or modify it under the terms of the GNU * General Public License version 2 as published by the Free Software * Foundation. */ #ifndef __MUSB_HDRDF_H__ #define __MUSB_HDRDF_H__ /* * DaVinci-specific definitions */ /* Integrated highspeed/otg PHY */ #define USBPHY_CTL_PADDR 0x01c40034 #define USBPHY_DATAPOL BIT(11) /* (dm355) switch D+/D- */ #define USBPHY_PHYCLKGD BIT(8) #define USBPHY_SESNDEN BIT(7) /* v(sess_end) comparator */ #define USBPHY_VBDTCTEN BIT(6) /* v(bus) comparator */ #define USBPHY_VBUSSENS BIT(5) /* (dm355,ro) is vbus > 0.5V */ #define USBPHY_PHYPLLON BIT(4) /* override pll suspend */ #define USBPHY_CLKO1SEL BIT(3) #define USBPHY_OSCPDWN BIT(2) #define USBPHY_OTGPDWN BIT(1) #define USBPHY_PHYPDWN BIT(0) #define DM355_DEEPSLEEP_PADDR 0x01c40048 #define DRVVBUS_FORCE BIT(2) #define DRVVBUS_OVERRIDE BIT(1) /* For now include usb OTG module registers here */ #define DAVINCI_USB_VERSION_REG 0x00 #define DAVINCI_USB_CTRL_REG 0x04 #define DAVINCI_USB_STAT_REG 0x08 #define DAVINCI_RNDIS_REG 0x10 #define DAVINCI_AUTOREQ_REG 0x14 #define DAVINCI_USB_INT_SOURCE_REG 0x20 #define DAVINCI_USB_INT_SET_REG 0x24 #define DAVINCI_USB_INT_SRC_CLR_REG 0x28 #define DAVINCI_USB_INT_MASK_REG 0x2c #define DAVINCI_USB_INT_MASK_SET_REG 0x30 #define DAVINCI_USB_INT_MASK_CLR_REG 0x34 #define DAVINCI_USB_INT_SRC_MASKED_REG 0x38 #define DAVINCI_USB_EOI_REG 0x3c #define DAVINCI_USB_EOI_INTVEC 0x40 /* BEGIN CPPI-generic (?) */ /* CPPI related registers */ #define DAVINCI_TXCPPI_CTRL_REG 0x80 #define DAVINCI_TXCPPI_TEAR_REG 0x84 #define DAVINCI_CPPI_EOI_REG 0x88 #define DAVINCI_CPPI_INTVEC_REG 0x8c #define DAVINCI_TXCPPI_MASKED_REG 0x90 #define DAVINCI_TXCPPI_RAW_REG 0x94 #define DAVINCI_TXCPPI_INTENAB_REG 0x98 #define DAVINCI_TXCPPI_INTCLR_REG 0x9c #define DAVINCI_RXCPPI_CTRL_REG 0xC0 #define DAVINCI_RXCPPI_MASKED_REG 0xD0 #define DAVINCI_RXCPPI_RAW_REG 0xD4 #define DAVINCI_RXCPPI_INTENAB_REG 0xD8 #define DAVINCI_RXCPPI_INTCLR_REG 0xDC #define DAVINCI_RXCPPI_BUFCNT0_REG 0xE0 #define DAVINCI_RXCPPI_BUFCNT1_REG 0xE4 #define DAVINCI_RXCPPI_BUFCNT2_REG 0xE8 #define DAVINCI_RXCPPI_BUFCNT3_REG 0xEC /* CPPI state RAM entries */ #define DAVINCI_CPPI_STATERAM_BASE_OFFSET 0x100 #define DAVINCI_TXCPPI_STATERAM_OFFSET(chnum) \ (DAVINCI_CPPI_STATERAM_BASE_OFFSET + ((chnum) * 0x40)) #define DAVINCI_RXCPPI_STATERAM_OFFSET(chnum) \ (DAVINCI_CPPI_STATERAM_BASE_OFFSET + 0x20 + ((chnum) * 0x40)) /* CPPI masks */ #define DAVINCI_DMA_CTRL_ENABLE 1 #define DAVINCI_DMA_CTRL_DISABLE 0 #define DAVINCI_DMA_ALL_CHANNELS_ENABLE 0xF #define DAVINCI_DMA_ALL_CHANNELS_DISABLE 0xF /* END CPPI-generic (?) */ #define DAVINCI_USB_TX_ENDPTS_MASK 0x1f /* ep0 + 4 tx */ #define DAVINCI_USB_RX_ENDPTS_MASK 0x1e /* 4 rx */ #define DAVINCI_USB_USBINT_SHIFT 16 #define DAVINCI_USB_TXINT_SHIFT 0 #define DAVINCI_USB_RXINT_SHIFT 8 #define DAVINCI_INTR_DRVVBUS 0x0100 #define DAVINCI_USB_USBINT_MASK 0x01ff0000 /* 8 Mentor, DRVVBUS */ #define DAVINCI_USB_TXINT_MASK \ (DAVINCI_USB_TX_ENDPTS_MASK << DAVINCI_USB_TXINT_SHIFT) #define DAVINCI_USB_RXINT_MASK \ (DAVINCI_USB_RX_ENDPTS_MASK << DAVINCI_USB_RXINT_SHIFT) #define DAVINCI_BASE_OFFSET 0x400 #endif /* __MUSB_HDRDF_H__ */ name='context' onchange='this.form.submit();'>space:mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /include/soc/rockchip
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/soc/rockchip')