/* * NXP ISP1301 USB transceiver driver * * Copyright (C) 2012 Roland Stigge * * Author: Roland Stigge * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #include #include #include #include #include #define DRV_NAME "isp1301" struct isp1301 { struct usb_phy phy; struct mutex mutex; struct i2c_client *client; }; #define phy_to_isp(p) (container_of((p), struct isp1301, phy)) static const struct i2c_device_id isp1301_id[] = { { "isp1301", 0 }, { } }; MODULE_DEVICE_TABLE(i2c, isp1301_id); static struct i2c_client *isp1301_i2c_client; static int __isp1301_write(struct isp1301 *isp, u8 reg, u8 value, u8 clear) { return i2c_smbus_write_byte_data(isp->client, reg | clear, value); } static int isp1301_write(struct isp1301 *isp, u8 reg, u8 value) { return __isp1301_write(isp, reg, value, 0); } static int isp1301_clear(struct isp1301 *isp, u8 reg, u8 value) { return __isp1301_write(isp, reg, value, ISP1301_I2C_REG_CLEAR_ADDR); } static int isp1301_phy_init(struct usb_phy *phy) { struct isp1301 *isp = phy_to_isp(phy); /* Disable transparent UART mode first */ isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_UART_EN); isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_1, ~MC1_SPEED_REG); isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_SPEED_REG); isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_2, ~0); isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_2, (MC2_BI_DI | MC2_PSW_EN | MC2_SPD_SUSP_CTRL)); isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, ~0); isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_DAT_SE0); isp1301_write(isp, ISP1301_I2C_OTG_CONTROL_1, (OTG1_DM_PULLDOWN | OTG1_DP_PULLDOWN)); isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, (OTG1_DM_PULLUP | OTG1_DP_PULLUP)); /* mask all interrupts */ isp1301_clear(isp, ISP1301_I2C_INTERRUPT_LATCH, ~0); isp1301_clear(isp, ISP1301_I2C_INTERRUPT_FALLING, ~0); isp1301_clear(isp, ISP1301_I2C_INTERRUPT_RISING, ~0); return 0; } static int isp1301_phy_set_vbus(struct usb_phy *phy, int on) { struct isp1301 *isp = phy_to_isp(phy); if (on) isp1301_write(isp, ISP1301_I2C_OTG_CONTROL_1, OTG1_VBUS_DRV); else isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, OTG1_VBUS_DRV); return 0; } static int isp1301_probe(struct i2c_client *client, const struct i2c_device_id *i2c_id) { struct isp1301 *isp; struct usb_phy *phy; isp = devm_kzalloc(&client->dev, sizeof(*isp), GFP_KERNEL); if (!isp) return -ENOMEM; isp->client = client; mutex_init(&isp->mutex); phy = &isp->phy; phy->dev = &client->dev; phy->label = DRV_NAME; phy->init = isp1301_phy_init; phy->set_vbus = isp1301_phy_set_vbus; phy->type = USB_PHY_TYPE_USB2; i2c_set_clientdata(client, isp); usb_add_phy_dev(phy); isp1301_i2c_client = client; return 0; } static int isp1301_remove(struct i2c_client *client) { struct isp1301 *isp = i2c_get_clientdata(client); usb_remove_phy(&isp->phy); isp1301_i2c_client = NULL; return 0; } static struct i2c_driver isp1301_driver = { .driver = { .name = DRV_NAME, }, .probe = isp1301_probe, .remove = isp1301_remove, .id_table = isp1301_id, }; module_i2c_driver(isp1301_driver); static int match(struct device *dev, void *data) { struct device_node *node = (struct device_node *)data; return (dev->of_node == node) && (dev->driver == &isp1301_driver.driver); } struct i2c_client *isp1301_get_client(struct device_node *node) { if (node) { /* reference of ISP1301 I2C node via DT */ struct device *dev = bus_find_device(&i2c_bus_type, NULL, node, match); if (!dev) return NULL; return to_i2c_client(dev); } else { /* non-DT: only one ISP1301 chip supported */ return isp1301_i2c_client; } } EXPORT_SYMBOL_GPL(isp1301_get_client); MODULE_AUTHOR("Roland Stigge "); MODULE_DESCRIPTION("NXP ISP1301 USB transceiver driver"); MODULE_LICENSE("GPL"); class='label'>space:mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /tools/laptop
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/laptop')