/* * NXP ISP1301 USB transceiver driver * * Copyright (C) 2012 Roland Stigge * * Author: Roland Stigge * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ #include #include #include #include #include #define DRV_NAME "isp1301" struct isp1301 { struct usb_phy phy; struct mutex mutex; struct i2c_client *client; }; #define phy_to_isp(p) (container_of((p), struct isp1301, phy)) static const struct i2c_device_id isp1301_id[] = { { "isp1301", 0 }, { } }; MODULE_DEVICE_TABLE(i2c, isp1301_id); static struct i2c_client *isp1301_i2c_client; static int __isp1301_write(struct isp1301 *isp, u8 reg, u8 value, u8 clear) { return i2c_smbus_write_byte_data(isp->client, reg | clear, value); } static int isp1301_write(struct isp1301 *isp, u8 reg, u8 value) { return __isp1301_write(isp, reg, value, 0); } static int isp1301_clear(struct isp1301 *isp, u8 reg, u8 value) { return __isp1301_write(isp, reg, value, ISP1301_I2C_REG_CLEAR_ADDR); } static int isp1301_phy_init(struct usb_phy *phy) { struct isp1301 *isp = phy_to_isp(phy); /* Disable transparent UART mode first */ isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_UART_EN); isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_1, ~MC1_SPEED_REG); isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_SPEED_REG); isp1301_clear(isp, ISP1301_I2C_MODE_CONTROL_2, ~0); isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_2, (MC2_BI_DI | MC2_PSW_EN | MC2_SPD_SUSP_CTRL)); isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, ~0); isp1301_write(isp, ISP1301_I2C_MODE_CONTROL_1, MC1_DAT_SE0); isp1301_write(isp, ISP1301_I2C_OTG_CONTROL_1, (OTG1_DM_PULLDOWN | OTG1_DP_PULLDOWN)); isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, (OTG1_DM_PULLUP | OTG1_DP_PULLUP)); /* mask all interrupts */ isp1301_clear(isp, ISP1301_I2C_INTERRUPT_LATCH, ~0); isp1301_clear(isp, ISP1301_I2C_INTERRUPT_FALLING, ~0); isp1301_clear(isp, ISP1301_I2C_INTERRUPT_RISING, ~0); return 0; } static int isp1301_phy_set_vbus(struct usb_phy *phy, int on) { struct isp1301 *isp = phy_to_isp(phy); if (on) isp1301_write(isp, ISP1301_I2C_OTG_CONTROL_1, OTG1_VBUS_DRV); else isp1301_clear(isp, ISP1301_I2C_OTG_CONTROL_1, OTG1_VBUS_DRV); return 0; } static int isp1301_probe(struct i2c_client *client, const struct i2c_device_id *i2c_id) { struct isp1301 *isp; struct usb_phy *phy; isp = devm_kzalloc(&client->dev, sizeof(*isp), GFP_KERNEL); if (!isp) return -ENOMEM; isp->client = client; mutex_init(&isp->mutex); phy = &isp->phy; phy->dev = &client->dev; phy->label = DRV_NAME; phy->init = isp1301_phy_init; phy->set_vbus = isp1301_phy_set_vbus; phy->type = USB_PHY_TYPE_USB2; i2c_set_clientdata(client, isp); usb_add_phy_dev(phy); isp1301_i2c_client = client; return 0; } static int isp1301_remove(struct i2c_client *client) { struct isp1301 *isp = i2c_get_clientdata(client); usb_remove_phy(&isp->phy); isp1301_i2c_client = NULL; return 0; } static struct i2c_driver isp1301_driver = { .driver = { .name = DRV_NAME, }, .probe = isp1301_probe, .remove = isp1301_remove, .id_table = isp1301_id, }; module_i2c_driver(isp1301_driver); static int match(struct device *dev, void *data) { struct device_node *node = (struct device_node *)data; return (dev->of_node == node) && (dev->driver == &isp1301_driver.driver); } struct i2c_client *isp1301_get_client(struct device_node *node) { if (node) { /* reference of ISP1301 I2C node via DT */ struct device *dev = bus_find_device(&i2c_bus_type, NULL, node, match); if (!dev) return NULL; return to_i2c_client(dev); } else { /* non-DT: only one ISP1301 chip supported */ return isp1301_i2c_client; } } EXPORT_SYMBOL_GPL(isp1301_get_client); MODULE_AUTHOR("Roland Stigge "); MODULE_DESCRIPTION("NXP ISP1301 USB transceiver driver"); MODULE_LICENSE("GPL"); ctrl'>mode:
authorVincent <vincent.stehle@laposte.net>2017-01-30 15:06:43 +0100
committerDavid S. Miller <davem@davemloft.net>2017-01-31 13:07:40 -0500
commitc73e44269369e936165f0f9b61f1f09a11dae01c (patch)
treee2188e900ba06302f8ed2746cb07edd3efbc5c35 /drivers/usb/core/port.c
parent040587af31228d82c52267f717c9fcdb65f36335 (diff)
net: thunderx: avoid dereferencing xcv when NULL
This fixes the following smatch and coccinelle warnings: drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119 xcv_setup_link() error: we previously assumed 'xcv' could be null (see line 118) [smatch] drivers/net/ethernet/cavium/thunder/thunder_xcv.c:119:16-20: ERROR: xcv is NULL but dereferenced. [coccinelle] Fixes: 6465859aba1e66a5 ("net: thunderx: Add RGMII interface type support") Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Sunil Goutham <sgoutham@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/usb/core/port.c')