/* * Definitions for the KLSI KL5KUSB105 serial port adapter */ /* vendor/product pairs that are known to contain this chipset */ #define PALMCONNECT_VID 0x0830 #define PALMCONNECT_PID 0x0080 #define KLSI_VID 0x05e9 #define KLSI_KL5KUSB105D_PID 0x00c0 /* Vendor commands: */ /* port table -- the chip supports up to 4 channels */ /* baud rates */ enum { kl5kusb105a_sio_b115200 = 0, kl5kusb105a_sio_b57600 = 1, kl5kusb105a_sio_b38400 = 2, kl5kusb105a_sio_b19200 = 4, kl5kusb105a_sio_b14400 = 5, kl5kusb105a_sio_b9600 = 6, kl5kusb105a_sio_b4800 = 8, /* unchecked */ kl5kusb105a_sio_b2400 = 9, /* unchecked */ kl5kusb105a_sio_b1200 = 0xa, /* unchecked */ kl5kusb105a_sio_b600 = 0xb /* unchecked */ }; /* data bits */ #define kl5kusb105a_dtb_7 7 #define kl5kusb105a_dtb_8 8 /* requests: */ #define KL5KUSB105A_SIO_SET_DATA 1 #define KL5KUSB105A_SIO_POLL 2 #define KL5KUSB105A_SIO_CONFIGURE 3 /* values used for request KL5KUSB105A_SIO_CONFIGURE */ #define KL5KUSB105A_SIO_CONFIGURE_READ_ON 3 #define KL5KUSB105A_SIO_CONFIGURE_READ_OFF 2 /* Interpretation of modem status lines */ /* These need sorting out by individually connecting pins and checking * results. FIXME! * When data is being sent we see 0x30 in the lower byte; this must * contain DSR and CTS ... */ #define KL5KUSB105A_DSR ((1<<4) | (1<<5)) #define KL5KUSB105A_CTS ((1<<5) | (1<<4)) #define KL5KUSB105A_WANTS_TO_SEND 0x30 #if 0 #define KL5KUSB105A_DTR /* Data Terminal Ready */ #define KL5KUSB105A_CTS /* Clear To Send */ #define KL5KUSB105A_CD /* Carrier Detect */ #define KL5KUSB105A_DSR /* Data Set Ready */ #define KL5KUSB105A_RxD /* Receive pin */ #define KL5KUSB105A_LE #define KL5KUSB105A_RTS #define KL5KUSB105A_ST #define KL5KUSB105A_SR #define KL5KUSB105A_RI /* Ring Indicator */ #endif oc/codecs/tlv320aic23-spi.c?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>treecommitdiff
path: root/sound/soc/codecs/tlv320aic23-spi.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/codecs/tlv320aic23-spi.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/codecs/tlv320aic23-spi.c')