/* * Fujitsu MB862xx Graphics Controller Registers/Bits */ #ifndef _MB862XX_REG_H #define _MB862XX_REG_H #define MB862XX_MMIO_BASE 0x01fc0000 #define MB862XX_MMIO_HIGH_BASE 0x03fc0000 #define MB862XX_I2C_BASE 0x0000c000 #define MB862XX_DISP_BASE 0x00010000 #define MB862XX_CAP_BASE 0x00018000 #define MB862XX_DRAW_BASE 0x00030000 #define MB862XX_GEO_BASE 0x00038000 #define MB862XX_PIO_BASE 0x00038000 #define MB862XX_MMIO_SIZE 0x40000 /* Host interface/pio registers */ #define GC_IST 0x00000020 #define GC_IMASK 0x00000024 #define GC_SRST 0x0000002c #define GC_CCF 0x00000038 #define GC_RSW 0x0000005c #define GC_CID 0x000000f0 #define GC_REVISION 0x00000084 #define GC_CCF_CGE_100 0x00000000 #define GC_CCF_CGE_133 0x00040000 #define GC_CCF_CGE_166 0x00080000 #define GC_CCF_COT_100 0x00000000 #define GC_CCF_COT_133 0x00010000 #define GC_CID_CNAME_MSK 0x0000ff00 #define GC_CID_VERSION_MSK 0x000000ff /* define enabled interrupts hereby */ #define GC_INT_EN 0x00000000 /* Memory interface mode register */ #define GC_MMR 0x0000fffc /* Display Controller registers */ #define GC_DCM0 0x00000000 #define GC_HTP 0x00000004 #define GC_HDB_HDP 0x00000008 #define GC_VSW_HSW_HSP 0x0000000c #define GC_VTR 0x00000010 #define GC_VDP_VSP 0x00000014 #define GC_WY_WX 0x00000018 #define GC_WH_WW 0x0000001c #define GC_L0M 0x00000020 #define GC_L0OA0 0x00000024 #define GC_L0DA0 0x00000028 #define GC_L0DY_L0DX 0x0000002c #define GC_L1M 0x00000030 #define GC_L1DA 0x00000034 #define GC_DCM1 0x00000100 #define GC_L0EM 0x00000110 #define GC_L0WY_L0WX 0x00000114 #define GC_L0WH_L0WW 0x00000118 #define GC_L1EM 0x00000120 #define GC_L1WY_L1WX 0x00000124 #define GC_L1WH_L1WW 0x00000128 #define GC_DLS 0x00000180 #define GC_DCM2 0x00000104 #define GC_DCM3 0x00000108 #define GC_CPM_CUTC 0x000000a0 #define GC_CUOA0 0x000000a4 #define GC_CUY0_CUX0 0x000000a8 #define GC_CUOA1 0x000000ac #define GC_CUY1_CUX1 0x000000b0 #define GC_L0PAL0 0x00000400 #define GC_CPM_CEN0 0x00100000 #define GC_CPM_CEN1 0x00200000 #define GC_DCM1_DEN 0x80000000 #define GC_DCM1_L1E 0x00020000 #define GC_L1M_16 0x80000000 #define GC_L1M_YC 0x40000000 #define GC_L1M_CS 0x20000000 #define GC_DCM01_ESY 0x00000004 #define GC_DCM01_SC 0x00003f00 #define GC_DCM01_RESV 0x00004000 #define GC_DCM01_CKS 0x00008000 #define GC_DCM01_L0E 0x00010000 #define GC_DCM01_DEN 0x80000000 #define GC_L0M_L0C_8 0x00000000 #define GC_L0M_L0C_16 0x80000000 #define GC_L0EM_L0EC_24 0x40000000 #define GC_L0M_L0W_UNIT 64 #define GC_L1EM_DM 0x02000000 #define GC_DISP_REFCLK_400 400 /* I2C */ #define GC_I2C_BSR 0x00000000 /* BSR */ #define GC_I2C_BCR 0x00000004 /* BCR */ #define GC_I2C_CCR 0x00000008 /* CCR */ #define GC_I2C_ADR 0x0000000C /* ADR */ #define GC_I2C_DAR 0x00000010 /* DAR */ #define I2C_DISABLE 0x00000000 #define I2C_STOP 0x00000000 #define I2C_START 0x00000010 #define I2C_REPEATED_START 0x00000030 #define I2C_CLOCK_AND_ENABLE 0x0000003f #define I2C_READY 0x01 #define I2C_INT 0x01 #define I2C_INTE 0x02 #define I2C_ACK 0x08 #define I2C_BER 0x80 #define I2C_BEIE 0x40 #define I2C_TRX 0x80 #define I2C_LRB 0x10 /* Capture registers and bits */ #define GC_CAP_VCM 0x00000000 #define GC_CAP_CSC 0x00000004 #define GC_CAP_VCS 0x00000008 #define GC_CAP_CBM 0x00000010 #define GC_CAP_CBOA 0x00000014 #define GC_CAP_CBLA 0x00000018 #define GC_CAP_IMG_START 0x0000001C #define GC_CAP_IMG_END 0x00000020 #define GC_CAP_CMSS 0x00000048 #define GC_CAP_CMDS 0x0000004C #define GC_VCM_VIE 0x80000000 #define GC_VCM_CM 0x03000000 #define GC_VCM_VS_PAL 0x00000002 #define GC_CBM_OO 0x80000000 #define GC_CBM_HRV 0x00000010 #define GC_CBM_CBST 0x00000001 /* Carmine specific */ #define MB86297_DRAW_BASE 0x00020000 #define MB86297_DISP0_BASE 0x00100000 #define MB86297_DISP1_BASE 0x00140000 #define MB86297_WRBACK_BASE 0x00180000 #define MB86297_CAP0_BASE 0x00200000 #define MB86297_CAP1_BASE 0x00280000 #define MB86297_DRAMCTRL_BASE 0x00300000 #define MB86297_CTRL_BASE 0x00400000 #define MB86297_I2C_BASE 0x00500000 #define GC_CTRL_STATUS 0x00000000 #define GC_CTRL_INT_MASK 0x00000004 #define GC_CTRL_CLK_ENABLE 0x0000000c #define GC_CTRL_SOFT_RST 0x00000010 #define GC_CTRL_CLK_EN_DRAM 0x00000001 #define GC_CTRL_CLK_EN_2D3D 0x00000002 #define GC_CTRL_CLK_EN_DISP0 0x00000020 #define GC_CTRL_CLK_EN_DISP1 0x00000040 #define GC_2D3D_REV 0x000004b4 #define GC_RE_REVISION 0x24240200 /* define enabled interrupts hereby */ #define GC_CARMINE_INT_EN 0x00000004 /* DRAM controller */ #define GC_DCTL_MODE_ADD 0x00000000 #define GC_DCTL_SETTIME1_EMODE 0x00000004 #define GC_DCTL_REFRESH_SETTIME2 0x00000008 #define GC_DCTL_RSV0_STATES 0x0000000C #define GC_DCTL_RSV2_RSV1 0x00000010 #define GC_DCTL_DDRIF2_DDRIF1 0x00000014 #define GC_DCTL_IOCONT1_IOCONT0 0x00000024 #define GC_DCTL_STATES_MSK 0x0000000f #define GC_DCTL_INIT_WAIT_CNT 3000 #define GC_DCTL_INIT_WAIT_INTERVAL 1 /* DRAM ctrl values for Carmine PCI Eval. board */ #define GC_EVB_DCTL_MODE_ADD 0x012105c3 #define GC_EVB_DCTL_MODE_ADD_AFT_RST 0x002105c3 #define GC_EVB_DCTL_SETTIME1_EMODE 0x47498000 #define GC_EVB_DCTL_REFRESH_SETTIME2 0x00422a22 #define GC_EVB_DCTL_RSV0_STATES 0x00200003 #define GC_EVB_DCTL_RSV0_STATES_AFT_RST 0x00200002 #define GC_EVB_DCTL_RSV2_RSV1 0x0000000f #define GC_EVB_DCTL_DDRIF2_DDRIF1 0x00556646 #define GC_EVB_DCTL_IOCONT1_IOCONT0 0x05550555 #define GC_DISP_REFCLK_533 533 #endif netns/generic.h?id=91539eb1fda2d530d3b268eef542c5414e54bf1a'>include/net/netns/generic.h parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/net/netns/generic.h')