/* * w1_family.c * * Copyright (c) 2004 Evgeniy Polyakov * * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include #include #include /* schedule_timeout() */ #include #include #include "w1_family.h" #include "w1.h" DEFINE_SPINLOCK(w1_flock); static LIST_HEAD(w1_families); /** * w1_register_family() - register a device family driver * @newf: family to register */ int w1_register_family(struct w1_family *newf) { struct list_head *ent, *n; struct w1_family *f; int ret = 0; spin_lock(&w1_flock); list_for_each_safe(ent, n, &w1_families) { f = list_entry(ent, struct w1_family, family_entry); if (f->fid == newf->fid) { ret = -EEXIST; break; } } if (!ret) { atomic_set(&newf->refcnt, 0); list_add_tail(&newf->family_entry, &w1_families); } spin_unlock(&w1_flock); /* check default devices against the new set of drivers */ w1_reconnect_slaves(newf, 1); return ret; } /** * w1_unregister_family() - unregister a device family driver * @fent: family to unregister */ void w1_unregister_family(struct w1_family *fent) { struct list_head *ent, *n; struct w1_family *f; spin_lock(&w1_flock); list_for_each_safe(ent, n, &w1_families) { f = list_entry(ent, struct w1_family, family_entry); if (f->fid == fent->fid) { list_del(&fent->family_entry); break; } } spin_unlock(&w1_flock); /* deatch devices using this family code */ w1_reconnect_slaves(fent, 0); while (atomic_read(&fent->refcnt)) { pr_info("Waiting for family %u to become free: refcnt=%d.\n", fent->fid, atomic_read(&fent->refcnt)); if (msleep_interruptible(1000)) flush_signals(current); } } /* * Should be called under w1_flock held. */ struct w1_family * w1_family_registered(u8 fid) { struct list_head *ent, *n; struct w1_family *f = NULL; int ret = 0; list_for_each_safe(ent, n, &w1_families) { f = list_entry(ent, struct w1_family, family_entry); if (f->fid == fid) { ret = 1; break; } } return (ret) ? f : NULL; } static void __w1_family_put(struct w1_family *f) { atomic_dec(&f->refcnt); } void w1_family_put(struct w1_family *f) { spin_lock(&w1_flock); __w1_family_put(f); spin_unlock(&w1_flock); } #if 0 void w1_family_get(struct w1_family *f) { spin_lock(&w1_flock); __w1_family_get(f); spin_unlock(&w1_flock); } #endif /* 0 */ void __w1_family_get(struct w1_family *f) { smp_mb__before_atomic(); atomic_inc(&f->refcnt); smp_mb__after_atomic(); } EXPORT_SYMBOL(w1_unregister_family); EXPORT_SYMBOL(w1_register_family); t'>
diff options
context:
space:
mode:
authorArd Biesheuvel <ard.biesheuvel@linaro.org>2017-02-01 17:45:02 +0000
committerIngo Molnar <mingo@kernel.org>2017-02-01 21:17:49 +0100
commitc8f325a59cfc718d13a50fbc746ed9b415c25e92 (patch)
treed53fbdac9d0781e39a13b2ac6b2bd258cf3b4140 /drivers/usb/core/message.c
parentbf29bddf0417a4783da3b24e8c9e017ac649326f (diff)
efi/fdt: Avoid FDT manipulation after ExitBootServices()
Some AArch64 UEFI implementations disable the MMU in ExitBootServices(), after which unaligned accesses to RAM are no longer supported. Commit: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") fixed an issue in the memory map handling of the stub FDT code, but inadvertently created an issue with such firmware, by moving some of the FDT manipulation to after the invocation of ExitBootServices(). Given that the stub's libfdt implementation uses the ordinary, accelerated string functions, which rely on hardware handling of unaligned accesses, manipulating the FDT with the MMU off may result in alignment faults. So fix the situation by moving the update_fdt_memmap() call into the callback function invoked by efi_exit_boot_services() right before it calls the ExitBootServices() UEFI service (which is arguably a better place for it anyway) Note that disabling the MMU in ExitBootServices() is not compliant with the UEFI spec, and carries great risk due to the fact that switching from cached to uncached memory accesses halfway through compiler generated code (i.e., involving a stack) can never be done in a way that is architecturally safe. Fixes: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Tested-by: Riku Voipio <riku.voipio@linaro.org> Cc: <stable@vger.kernel.org> Cc: mark.rutland@arm.com Cc: linux-efi@vger.kernel.org Cc: matt@codeblueprint.co.uk Cc: leif.lindholm@linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1485971102-23330-2-git-send-email-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'drivers/usb/core/message.c')