#include #include #include #include #include #include int xen_event_channel_op_compat(int cmd, void *arg) { struct evtchn_op op; int rc; op.cmd = cmd; memcpy(&op.u, arg, sizeof(op.u)); rc = _hypercall1(int, event_channel_op_compat, &op); switch (cmd) { case EVTCHNOP_close: case EVTCHNOP_send: case EVTCHNOP_bind_vcpu: case EVTCHNOP_unmask: /* no output */ break; #define COPY_BACK(eop) \ case EVTCHNOP_##eop: \ memcpy(arg, &op.u.eop, sizeof(op.u.eop)); \ break COPY_BACK(bind_interdomain); COPY_BACK(bind_virq); COPY_BACK(bind_pirq); COPY_BACK(status); COPY_BACK(alloc_unbound); COPY_BACK(bind_ipi); #undef COPY_BACK default: WARN_ON(rc != -ENOSYS); break; } return rc; } EXPORT_SYMBOL_GPL(xen_event_channel_op_compat); int xen_physdev_op_compat(int cmd, void *arg) { struct physdev_op op; int rc; op.cmd = cmd; memcpy(&op.u, arg, sizeof(op.u)); rc = _hypercall1(int, physdev_op_compat, &op); switch (cmd) { case PHYSDEVOP_IRQ_UNMASK_NOTIFY: case PHYSDEVOP_set_iopl: case PHYSDEVOP_set_iobitmap: case PHYSDEVOP_apic_write: /* no output */ break; #define COPY_BACK(pop, fld) \ case PHYSDEVOP_##pop: \ memcpy(arg, &op.u.fld, sizeof(op.u.fld)); \ break COPY_BACK(irq_status_query, irq_status_query); COPY_BACK(apic_read, apic_op); COPY_BACK(ASSIGN_VECTOR, irq_op); #undef COPY_BACK default: WARN_ON(rc != -ENOSYS); break; } return rc; } EXPORT_SYMBOL_GPL(xen_physdev_op_compat); '> summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc Zyngier <marc.zyngier@arm.com>2017-01-17 16:00:48 +0000
committerThomas Gleixner <tglx@linutronix.de>2017-01-30 15:18:56 +0100
commit08d85f3ea99f1eeafc4e8507936190e86a16ee8c (patch)
tree410bb1acd0cd7dcfaad37ae7b63ff243b7fa4bee /sound/ppc/pmac.c
parent566cf877a1fcb6d6dc0126b076aad062054c2637 (diff)
irqdomain: Avoid activating interrupts more than once
Since commit f3b0946d629c ("genirq/msi: Make sure PCI MSIs are activated early"), we can end-up activating a PCI/MSI twice (once at allocation time, and once at startup time). This is normally of no consequences, except that there is some HW out there that may misbehave if activate is used more than once (the GICv3 ITS, for example, uses the activate callback to issue the MAPVI command, and the architecture spec says that "If there is an existing mapping for the EventID-DeviceID combination, behavior is UNPREDICTABLE"). While this could be worked around in each individual driver, it may make more sense to tackle the issue at the core level. In order to avoid getting in that situation, let's have a per-interrupt flag to remember if we have already activated that interrupt or not. Fixes: f3b0946d629c ("genirq/msi: Make sure PCI MSIs are activated early") Reported-and-tested-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1484668848-24361-1-git-send-email-marc.zyngier@arm.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'sound/ppc/pmac.c')