/* * linux/fs/ncpfs/symlink.c * * Code for allowing symbolic links on NCPFS (i.e. NetWare) * Symbolic links are not supported on native NetWare, so we use an * infrequently-used flag (Sh) and store a two-word magic header in * the file to make sure we don't accidentally use a non-link file * as a link. * * When using the NFS namespace, we set the mode to indicate a symlink and * don't bother with the magic numbers. * * from linux/fs/ext2/symlink.c * * Copyright (C) 1998-99, Frank A. Vorstenbosch * * ncpfs symlink handling code * NLS support (c) 1999 Petr Vandrovec * Modified 2000 Ben Harris, University of Cambridge for NFS NS meta-info * */ #include #include #include #include #include #include #include #include "ncp_fs.h" /* these magic numbers must appear in the symlink file -- this makes it a bit more resilient against the magic attributes being set on random files. */ #define NCP_SYMLINK_MAGIC0 cpu_to_le32(0x6c6d7973) /* "symlnk->" */ #define NCP_SYMLINK_MAGIC1 cpu_to_le32(0x3e2d6b6e) /* ----- read a symbolic link ------------------------------------------ */ static int ncp_symlink_readpage(struct file *file, struct page *page) { struct inode *inode = page->mapping->host; int error, length, len; char *link, *rawlink; char *buf = kmap(page); error = -ENOMEM; rawlink = kmalloc(NCP_MAX_SYMLINK_SIZE, GFP_KERNEL); if (!rawlink) goto fail; if (ncp_make_open(inode,O_RDONLY)) goto failEIO; error=ncp_read_kernel(NCP_SERVER(inode),NCP_FINFO(inode)->file_handle, 0,NCP_MAX_SYMLINK_SIZE,rawlink,&length); ncp_inode_close(inode); /* Close file handle if no other users... */ ncp_make_closed(inode); if (error) goto failEIO; if (NCP_FINFO(inode)->flags & NCPI_KLUDGE_SYMLINK) { if (lengthvolNumber)) kludge = 0; else #ifdef CONFIG_NCPFS_EXTRAS if (NCP_SERVER(dir)->m.flags & NCP_MOUNT_SYMLINKS) kludge = 1; else #endif /* EPERM is returned by VFS if symlink procedure does not exist */ return -EPERM; rawlink = kmalloc(NCP_MAX_SYMLINK_SIZE, GFP_KERNEL); if (!rawlink) return -ENOMEM; if (kludge) { mode = 0; attr = aSHARED | aHIDDEN; ((__le32 *)rawlink)[0]=NCP_SYMLINK_MAGIC0; ((__le32 *)rawlink)[1]=NCP_SYMLINK_MAGIC1; hdr = 8; } else { mode = S_IFLNK | S_IRWXUGO; attr = 0; hdr = 0; } length = strlen(symname); /* map to/from server charset, do not touch upper/lower case as symlink can point out of ncp filesystem */ outlen = NCP_MAX_SYMLINK_SIZE - hdr; err = ncp_io2vol(NCP_SERVER(dir), rawlink + hdr, &outlen, symname, length, 0); if (err) goto failfree; outlen += hdr; err = -EIO; if (ncp_create_new(dir,dentry,mode,0,attr)) { goto failfree; } inode=d_inode(dentry); if (ncp_make_open(inode, O_WRONLY)) goto failfree; if (ncp_write_kernel(NCP_SERVER(inode), NCP_FINFO(inode)->file_handle, 0, outlen, rawlink, &i) || i!=outlen) { goto fail; } ncp_inode_close(inode); ncp_make_closed(inode); kfree(rawlink); return 0; fail:; ncp_inode_close(inode); ncp_make_closed(inode); failfree:; kfree(rawlink); return err; } /* ----- EOF ----- */ n>space:mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /tools/perf/bench/futex-hash.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools/perf/bench/futex-hash.c')