/* * (C) 2001 Clemson University and The University of Chicago * * See COPYING in top-level directory. */ /* * Definitions of downcalls used in Linux kernel module. */ #ifndef __DOWNCALL_H #define __DOWNCALL_H /* * Sanitized the device-client core interaction * for clean 32-64 bit usage */ struct orangefs_io_response { __s64 amt_complete; }; struct orangefs_lookup_response { struct orangefs_object_kref refn; }; struct orangefs_create_response { struct orangefs_object_kref refn; }; struct orangefs_symlink_response { struct orangefs_object_kref refn; }; struct orangefs_getattr_response { struct ORANGEFS_sys_attr_s attributes; char link_target[ORANGEFS_NAME_MAX]; }; struct orangefs_mkdir_response { struct orangefs_object_kref refn; }; /* * duplication of some system interface structures so that I don't have * to allocate extra memory */ struct orangefs_dirent { char *d_name; int d_length; struct orangefs_khandle khandle; }; struct orangefs_statfs_response { __s64 block_size; __s64 blocks_total; __s64 blocks_avail; __s64 files_total; __s64 files_avail; }; struct orangefs_fs_mount_response { __s32 fs_id; __s32 id; struct orangefs_khandle root_khandle; }; /* the getxattr response is the attribute value */ struct orangefs_getxattr_response { __s32 val_sz; __s32 __pad1; char val[ORANGEFS_MAX_XATTR_VALUELEN]; }; /* the listxattr response is an array of attribute names */ struct orangefs_listxattr_response { __s32 returned_count; __s32 __pad1; __u64 token; char key[ORANGEFS_MAX_XATTR_LISTLEN * ORANGEFS_MAX_XATTR_NAMELEN]; __s32 keylen; __s32 __pad2; __s32 lengths[ORANGEFS_MAX_XATTR_LISTLEN]; }; struct orangefs_param_response { union { __s64 value64; __s32 value32[2]; } u; }; #define PERF_COUNT_BUF_SIZE 4096 struct orangefs_perf_count_response { char buffer[PERF_COUNT_BUF_SIZE]; }; #define FS_KEY_BUF_SIZE 4096 struct orangefs_fs_key_response { __s32 fs_keylen; __s32 __pad1; char fs_key[FS_KEY_BUF_SIZE]; }; /* 2.9.6 */ struct orangefs_features_response { __u64 features; }; struct orangefs_downcall_s { __s32 type; __s32 status; /* currently trailer is used only by readdir */ __s64 trailer_size; char *trailer_buf; union { struct orangefs_io_response io; struct orangefs_lookup_response lookup; struct orangefs_create_response create; struct orangefs_symlink_response sym; struct orangefs_getattr_response getattr; struct orangefs_mkdir_response mkdir; struct orangefs_statfs_response statfs; struct orangefs_fs_mount_response fs_mount; struct orangefs_getxattr_response getxattr; struct orangefs_listxattr_response listxattr; struct orangefs_param_response param; struct orangefs_perf_count_response perf_count; struct orangefs_fs_key_response fs_key; struct orangefs_features_response features; } resp; }; struct orangefs_readdir_response_s { __u64 token; __u64 directory_version; __u32 __pad2; __u32 orangefs_dirent_outcount; struct orangefs_dirent *dirent_array; }; #endif /* __DOWNCALL_H */ e id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>auth_gss
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/sunrpc/auth_gss
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/sunrpc/auth_gss')