#ifndef __XFS_MESSAGE_H #define __XFS_MESSAGE_H 1 struct xfs_mount; extern __printf(2, 3) void xfs_emerg(const struct xfs_mount *mp, const char *fmt, ...); extern __printf(2, 3) void xfs_alert(const struct xfs_mount *mp, const char *fmt, ...); extern __printf(3, 4) void xfs_alert_tag(const struct xfs_mount *mp, int tag, const char *fmt, ...); extern __printf(2, 3) void xfs_crit(const struct xfs_mount *mp, const char *fmt, ...); extern __printf(2, 3) void xfs_err(const struct xfs_mount *mp, const char *fmt, ...); extern __printf(2, 3) void xfs_warn(const struct xfs_mount *mp, const char *fmt, ...); extern __printf(2, 3) void xfs_notice(const struct xfs_mount *mp, const char *fmt, ...); extern __printf(2, 3) void xfs_info(const struct xfs_mount *mp, const char *fmt, ...); #ifdef DEBUG extern __printf(2, 3) void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...); #else static inline __printf(2, 3) void xfs_debug(const struct xfs_mount *mp, const char *fmt, ...) { } #endif #define xfs_printk_ratelimited(func, dev, fmt, ...) \ do { \ static DEFINE_RATELIMIT_STATE(_rs, \ DEFAULT_RATELIMIT_INTERVAL, \ DEFAULT_RATELIMIT_BURST); \ if (__ratelimit(&_rs)) \ func(dev, fmt, ##__VA_ARGS__); \ } while (0) #define xfs_emerg_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_emerg, dev, fmt, ##__VA_ARGS__) #define xfs_alert_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_alert, dev, fmt, ##__VA_ARGS__) #define xfs_crit_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_crit, dev, fmt, ##__VA_ARGS__) #define xfs_err_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_err, dev, fmt, ##__VA_ARGS__) #define xfs_warn_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_warn, dev, fmt, ##__VA_ARGS__) #define xfs_notice_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_notice, dev, fmt, ##__VA_ARGS__) #define xfs_info_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_info, dev, fmt, ##__VA_ARGS__) #define xfs_debug_ratelimited(dev, fmt, ...) \ xfs_printk_ratelimited(xfs_debug, dev, fmt, ##__VA_ARGS__) extern void assfail(char *expr, char *f, int l); extern void asswarn(char *expr, char *f, int l); extern void xfs_hex_dump(void *p, int length); #endif /* __XFS_MESSAGE_H */ 68eef542c5414e54bf1a'/>
path: root/net/core/net_namespace.c
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /net/core/net_namespace.c
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'net/core/net_namespace.c')