/* * Software async multibuffer crypto daemon headers * * Author: * Tim Chen * * Copyright (c) 2014, Intel Corporation. */ #ifndef _CRYPTO_MCRYPT_H #define _CRYPTO_MCRYPT_H #include #include #include struct mcryptd_ahash { struct crypto_ahash base; }; static inline struct mcryptd_ahash *__mcryptd_ahash_cast( struct crypto_ahash *tfm) { return (struct mcryptd_ahash *)tfm; } struct mcryptd_cpu_queue { struct crypto_queue queue; struct work_struct work; }; struct mcryptd_queue { struct mcryptd_cpu_queue __percpu *cpu_queue; }; struct mcryptd_instance_ctx { struct crypto_spawn spawn; struct mcryptd_queue *queue; }; struct mcryptd_hash_ctx { struct crypto_ahash *child; struct mcryptd_alg_state *alg_state; }; struct mcryptd_tag { /* seq number of request */ unsigned seq_num; /* arrival time of request */ unsigned long arrival; unsigned long expire; int cpu; }; struct mcryptd_hash_request_ctx { struct list_head waiter; crypto_completion_t complete; struct mcryptd_tag tag; struct crypto_hash_walk walk; u8 *out; int flag; struct ahash_request areq; }; struct mcryptd_ahash *mcryptd_alloc_ahash(const char *alg_name, u32 type, u32 mask); struct crypto_ahash *mcryptd_ahash_child(struct mcryptd_ahash *tfm); struct ahash_request *mcryptd_ahash_desc(struct ahash_request *req); void mcryptd_free_ahash(struct mcryptd_ahash *tfm); void mcryptd_flusher(struct work_struct *work); enum mcryptd_req_type { MCRYPTD_NONE, MCRYPTD_UPDATE, MCRYPTD_FINUP, MCRYPTD_DIGEST, MCRYPTD_FINAL }; struct mcryptd_alg_cstate { unsigned long next_flush; unsigned next_seq_num; bool flusher_engaged; struct delayed_work flush; int cpu; struct mcryptd_alg_state *alg_state; void *mgr; spinlock_t work_lock; struct list_head work_list; struct list_head flush_list; }; struct mcryptd_alg_state { struct mcryptd_alg_cstate __percpu *alg_cstate; unsigned long (*flusher)(struct mcryptd_alg_cstate *cstate); }; /* return delay in jiffies from current time */ static inline unsigned long get_delay(unsigned long t) { long delay; delay = (long) t - (long) jiffies; if (delay <= 0) return 0; else return (unsigned long) delay; } void mcryptd_arm_flusher(struct mcryptd_alg_cstate *cstate, unsigned long delay); #endif mmitter
path: root/net/rds
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/rds
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/rds')