/* * Copyright 2014 Oleksij Rempel * * This software is licensed under the terms of the GNU General Public * License version 2, as published by the Free Software Foundation, and * may be copied, distributed, and modified under those terms. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ #ifndef _DT_BINDINGS_CLK_ASM9260_H #define _DT_BINDINGS_CLK_ASM9260_H /* ahb gate */ #define CLKID_AHB_ROM 0 #define CLKID_AHB_RAM 1 #define CLKID_AHB_GPIO 2 #define CLKID_AHB_MAC 3 #define CLKID_AHB_EMI 4 #define CLKID_AHB_USB0 5 #define CLKID_AHB_USB1 6 #define CLKID_AHB_DMA0 7 #define CLKID_AHB_DMA1 8 #define CLKID_AHB_UART0 9 #define CLKID_AHB_UART1 10 #define CLKID_AHB_UART2 11 #define CLKID_AHB_UART3 12 #define CLKID_AHB_UART4 13 #define CLKID_AHB_UART5 14 #define CLKID_AHB_UART6 15 #define CLKID_AHB_UART7 16 #define CLKID_AHB_UART8 17 #define CLKID_AHB_UART9 18 #define CLKID_AHB_I2S0 19 #define CLKID_AHB_I2C0 20 #define CLKID_AHB_I2C1 21 #define CLKID_AHB_SSP0 22 #define CLKID_AHB_IOCONFIG 23 #define CLKID_AHB_WDT 24 #define CLKID_AHB_CAN0 25 #define CLKID_AHB_CAN1 26 #define CLKID_AHB_MPWM 27 #define CLKID_AHB_SPI0 28 #define CLKID_AHB_SPI1 29 #define CLKID_AHB_QEI 30 #define CLKID_AHB_QUADSPI0 31 #define CLKID_AHB_CAMIF 32 #define CLKID_AHB_LCDIF 33 #define CLKID_AHB_TIMER0 34 #define CLKID_AHB_TIMER1 35 #define CLKID_AHB_TIMER2 36 #define CLKID_AHB_TIMER3 37 #define CLKID_AHB_IRQ 38 #define CLKID_AHB_RTC 39 #define CLKID_AHB_NAND 40 #define CLKID_AHB_ADC0 41 #define CLKID_AHB_LED 42 #define CLKID_AHB_DAC0 43 #define CLKID_AHB_LCD 44 #define CLKID_AHB_I2S1 45 #define CLKID_AHB_MAC1 46 /* devider */ #define CLKID_SYS_CPU 47 #define CLKID_SYS_AHB 48 #define CLKID_SYS_I2S0M 49 #define CLKID_SYS_I2S0S 50 #define CLKID_SYS_I2S1M 51 #define CLKID_SYS_I2S1S 52 #define CLKID_SYS_UART0 53 #define CLKID_SYS_UART1 54 #define CLKID_SYS_UART2 55 #define CLKID_SYS_UART3 56 #define CLKID_SYS_UART4 56 #define CLKID_SYS_UART5 57 #define CLKID_SYS_UART6 58 #define CLKID_SYS_UART7 59 #define CLKID_SYS_UART8 60 #define CLKID_SYS_UART9 61 #define CLKID_SYS_SPI0 62 #define CLKID_SYS_SPI1 63 #define CLKID_SYS_QUADSPI 64 #define CLKID_SYS_SSP0 65 #define CLKID_SYS_NAND 66 #define CLKID_SYS_TRACE 67 #define CLKID_SYS_CAMM 68 #define CLKID_SYS_WDT 69 #define CLKID_SYS_CLKOUT 70 #define CLKID_SYS_MAC 71 #define CLKID_SYS_LCD 72 #define CLKID_SYS_ADCANA 73 #define MAX_CLKS 74 #endif t.cgi/linux/net-next.git/commit/?id=92c715fca907686f5298220ece53423e38ba3aed'>root/drivers/usb/wusbcore/rh.c
diff options
context:
space:
mode:
authorMaarten Lankhorst <maarten.lankhorst@linux.intel.com>2017-01-31 10:25:25 +0100
committerDaniel Vetter <daniel.vetter@ffwll.ch>2017-01-31 13:41:46 +0100
commit92c715fca907686f5298220ece53423e38ba3aed (patch)
tree286158fdad04c9b54955350abb95d4f1c0dc860a /drivers/usb/wusbcore/rh.c
parente6e7b48b295afa5a5ab440de0a94d9ad8b3ce2d0 (diff)
drm/atomic: Fix double free in drm_atomic_state_default_clear
drm_atomic_helper_page_flip and drm_atomic_ioctl set their own events in crtc_state->event. But when it's set the event is freed in 2 places. Solve this by only freeing the event in the atomic ioctl when it allocated its own event. This has been broken twice. The first time when the code was introduced, but only in the corner case when an event is allocated, but more crtc's were included by atomic check and then failing. This can mostly happen when you do an atomic modeset in i915 and the display clock is changed, which forces all crtc's to be included to the state. This has been broken worse by adding in-fences support, which caused the double free to be done unconditionally. [IGT] kms_rotation_crc: starting subtest primary-rotation-180 ============================================================================= BUG kmalloc-128 (Tainted: G U ): Object already free ----------------------------------------------------------------------------- Disabling lock debugging due to kernel taint INFO: Allocated in drm_atomic_helper_setup_commit+0x285/0x2f0 [drm_kms_helper] age=0 cpu=3 pid=1529 ___slab_alloc+0x308/0x3b0 __slab_alloc+0xd/0x20 kmem_cache_alloc_trace+0x92/0x1c0 drm_atomic_helper_setup_commit+0x285/0x2f0 [drm_kms_helper] intel_atomic_commit+0x35/0x4f0 [i915] drm_atomic_commit+0x46/0x50 [drm] drm_mode_atomic_ioctl+0x7d4/0xab0 [drm] drm_ioctl+0x2b3/0x490 [drm] do_vfs_ioctl+0x69c/0x700 SyS_ioctl+0x4e/0x80 entry_SYSCALL_64_fastpath+0x13/0x94 INFO: Freed in drm_event_cancel_free+0xa3/0xb0 [drm] age=0 cpu=3 pid=1529 __slab_free+0x48/0x2e0 kfree+0x159/0x1a0 drm_event_cancel_free+0xa3/0xb0 [drm] drm_mode_atomic_ioctl+0x86d/0xab0 [drm] drm_ioctl+0x2b3/0x490 [drm] do_vfs_ioctl+0x69c/0x700 SyS_ioctl+0x4e/0x80 entry_SYSCALL_64_fastpath+0x13/0x94 INFO: Slab 0xffffde1f0997b080 objects=17 used=2 fp=0xffff92fb65ec2578 flags=0x200000000008101 INFO: Object 0xffff92fb65ec2578 @offset=1400 fp=0xffff92fb65ec2ae8 Redzone ffff92fb65ec2570: bb bb bb bb bb bb bb bb ........ Object ffff92fb65ec2578: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec2588: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec2598: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25a8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25b8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25c8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25d8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25e8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5 kkkkkkkkkkkkkkk. Redzone ffff92fb65ec25f8: bb bb bb bb bb bb bb bb ........ Padding ffff92fb65ec2738: 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZ CPU: 3 PID: 180 Comm: kworker/3:2 Tainted: G BU 4.10.0-rc6-patser+ #5039 Hardware name: /NUC5PPYB, BIOS PYBSWCEL.86A.0031.2015.0601.1712 06/01/2015 Workqueue: events intel_atomic_helper_free_state [i915] Call Trace: dump_stack+0x4d/0x6d print_trailer+0x20c/0x220 free_debug_processing+0x1c6/0x330 ? drm_atomic_state_default_clear+0xf7/0x1c0 [drm] __slab_free+0x48/0x2e0 ? drm_atomic_state_default_clear+0xf7/0x1c0 [drm] kfree+0x159/0x1a0 drm_atomic_state_default_clear+0xf7/0x1c0 [drm] ? drm_atomic_state_clear+0x30/0x30 [drm] intel_atomic_state_clear+0xd/0x20 [i915] drm_atomic_state_clear+0x1a/0x30 [drm] __drm_atomic_state_free+0x13/0x60 [drm] intel_atomic_helper_free_state+0x5d/0x70 [i915] process_one_work+0x260/0x4a0 worker_thread+0x2d1/0x4f0 kthread+0x127/0x130 ? process_one_work+0x4a0/0x4a0 ? kthread_stop+0x120/0x120 ret_from_fork+0x29/0x40 FIX kmalloc-128: Object at 0xffff92fb65ec2578 not freed Fixes: 3b24f7d67581 ("drm/atomic: Add struct drm_crtc_commit to track async updates") Fixes: 9626014258a5 ("drm/fence: add in-fences support") Cc: <stable@vger.kernel.org> # v4.8+ Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1485854725-27640-1-git-send-email-maarten.lankhorst@linux.intel.com
Diffstat (limited to 'drivers/usb/wusbcore/rh.c')