/* * Copyright 2015 Linaro Limited * * This software is licensed under the terms of the GNU General Public * License version 2, as published by the Free Software Foundation, and * may be copied, distributed, and modified under those terms. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ #ifndef _DT_BINDINGS_CLK_MSM_RPMCC_H #define _DT_BINDINGS_CLK_MSM_RPMCC_H /* apq8064 */ #define RPM_PXO_CLK 0 #define RPM_PXO_A_CLK 1 #define RPM_CXO_CLK 2 #define RPM_CXO_A_CLK 3 #define RPM_APPS_FABRIC_CLK 4 #define RPM_APPS_FABRIC_A_CLK 5 #define RPM_CFPB_CLK 6 #define RPM_CFPB_A_CLK 7 #define RPM_QDSS_CLK 8 #define RPM_QDSS_A_CLK 9 #define RPM_DAYTONA_FABRIC_CLK 10 #define RPM_DAYTONA_FABRIC_A_CLK 11 #define RPM_EBI1_CLK 12 #define RPM_EBI1_A_CLK 13 #define RPM_MM_FABRIC_CLK 14 #define RPM_MM_FABRIC_A_CLK 15 #define RPM_MMFPB_CLK 16 #define RPM_MMFPB_A_CLK 17 #define RPM_SYS_FABRIC_CLK 18 #define RPM_SYS_FABRIC_A_CLK 19 #define RPM_SFPB_CLK 20 #define RPM_SFPB_A_CLK 21 /* msm8916 */ #define RPM_SMD_XO_CLK_SRC 0 #define RPM_SMD_XO_A_CLK_SRC 1 #define RPM_SMD_PCNOC_CLK 2 #define RPM_SMD_PCNOC_A_CLK 3 #define RPM_SMD_SNOC_CLK 4 #define RPM_SMD_SNOC_A_CLK 5 #define RPM_SMD_BIMC_CLK 6 #define RPM_SMD_BIMC_A_CLK 7 #define RPM_SMD_QDSS_CLK 8 #define RPM_SMD_QDSS_A_CLK 9 #define RPM_SMD_BB_CLK1 10 #define RPM_SMD_BB_CLK1_A 11 #define RPM_SMD_BB_CLK2 12 #define RPM_SMD_BB_CLK2_A 13 #define RPM_SMD_RF_CLK1 14 #define RPM_SMD_RF_CLK1_A 15 #define RPM_SMD_RF_CLK2 16 #define RPM_SMD_RF_CLK2_A 17 #define RPM_SMD_BB_CLK1_PIN 18 #define RPM_SMD_BB_CLK1_A_PIN 19 #define RPM_SMD_BB_CLK2_PIN 20 #define RPM_SMD_BB_CLK2_A_PIN 21 #define RPM_SMD_RF_CLK1_PIN 22 #define RPM_SMD_RF_CLK1_A_PIN 23 #define RPM_SMD_RF_CLK2_PIN 24 #define RPM_SMD_RF_CLK2_A_PIN 25 #endif e55b6672d5a37e'>diff
path: root/net/ceph/osd_client.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /net/ceph/osd_client.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/ceph/osd_client.c')