/* * Copyright 2014 Ulrich Hecht * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. */ #ifndef __DT_BINDINGS_CLOCK_SH73A0_H__ #define __DT_BINDINGS_CLOCK_SH73A0_H__ /* CPG */ #define SH73A0_CLK_MAIN 0 #define SH73A0_CLK_PLL0 1 #define SH73A0_CLK_PLL1 2 #define SH73A0_CLK_PLL2 3 #define SH73A0_CLK_PLL3 4 #define SH73A0_CLK_DSI0PHY 5 #define SH73A0_CLK_DSI1PHY 6 #define SH73A0_CLK_ZG 7 #define SH73A0_CLK_M3 8 #define SH73A0_CLK_B 9 #define SH73A0_CLK_M1 10 #define SH73A0_CLK_M2 11 #define SH73A0_CLK_Z 12 #define SH73A0_CLK_ZX 13 #define SH73A0_CLK_HP 14 /* MSTP0 */ #define SH73A0_CLK_IIC2 1 #define SH73A0_CLK_MSIOF0 0 /* MSTP1 */ #define SH73A0_CLK_CEU1 29 #define SH73A0_CLK_CSI2_RX1 28 #define SH73A0_CLK_CEU0 27 #define SH73A0_CLK_CSI2_RX0 26 #define SH73A0_CLK_TMU0 25 #define SH73A0_CLK_DSITX0 18 #define SH73A0_CLK_IIC0 16 #define SH73A0_CLK_SGX 12 #define SH73A0_CLK_LCDC0 0 /* MSTP2 */ #define SH73A0_CLK_SCIFA7 19 #define SH73A0_CLK_SY_DMAC 18 #define SH73A0_CLK_MP_DMAC 17 #define SH73A0_CLK_MSIOF3 15 #define SH73A0_CLK_MSIOF1 8 #define SH73A0_CLK_SCIFA5 7 #define SH73A0_CLK_SCIFB 6 #define SH73A0_CLK_MSIOF2 5 #define SH73A0_CLK_SCIFA0 4 #define SH73A0_CLK_SCIFA1 3 #define SH73A0_CLK_SCIFA2 2 #define SH73A0_CLK_SCIFA3 1 #define SH73A0_CLK_SCIFA4 0 /* MSTP3 */ #define SH73A0_CLK_SCIFA6 31 #define SH73A0_CLK_CMT1 29 #define SH73A0_CLK_FSI 28 #define SH73A0_CLK_IRDA 25 #define SH73A0_CLK_IIC1 23 #define SH73A0_CLK_USB 22 #define SH73A0_CLK_FLCTL 15 #define SH73A0_CLK_SDHI0 14 #define SH73A0_CLK_SDHI1 13 #define SH73A0_CLK_MMCIF0 12 #define SH73A0_CLK_SDHI2 11 #define SH73A0_CLK_TPU0 4 #define SH73A0_CLK_TPU1 3 #define SH73A0_CLK_TPU2 2 #define SH73A0_CLK_TPU3 1 #define SH73A0_CLK_TPU4 0 /* MSTP4 */ #define SH73A0_CLK_IIC3 11 #define SH73A0_CLK_IIC4 10 #define SH73A0_CLK_KEYSC 3 /* MSTP5 */ #define SH73A0_CLK_INTCA0 8 #endif 96c543e55b6672d5a37e'>diff
path: root/sound/soc/codecs/cs35l33.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/codecs/cs35l33.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/codecs/cs35l33.c')