/* * Copyright (C) 2016 Maxime Ripard * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual * licensing only applies to this file, and not this project as a * whole. * * a) This file is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of the * License, or (at your option) any later version. * * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * Or, alternatively, * * b) Permission is hereby granted, free of charge, to any person * obtaining a copy of this software and associated documentation * files (the "Software"), to deal in the Software without * restriction, including without limitation the rights to use, * copy, modify, merge, publish, distribute, sublicense, and/or * sell copies of the Software, and to permit persons to whom the * Software is furnished to do so, subject to the following * conditions: * * The above copyright notice and this permission notice shall be * included in all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. */ #ifndef _DT_BINDINGS_CLK_SUN50I_A64_H_ #define _DT_BINDINGS_CLK_SUN50I_A64_H_ #define CLK_BUS_MIPI_DSI 28 #define CLK_BUS_CE 29 #define CLK_BUS_DMA 30 #define CLK_BUS_MMC0 31 #define CLK_BUS_MMC1 32 #define CLK_BUS_MMC2 33 #define CLK_BUS_NAND 34 #define CLK_BUS_DRAM 35 #define CLK_BUS_EMAC 36 #define CLK_BUS_TS 37 #define CLK_BUS_HSTIMER 38 #define CLK_BUS_SPI0 39 #define CLK_BUS_SPI1 40 #define CLK_BUS_OTG 41 #define CLK_BUS_EHCI0 42 #define CLK_BUS_EHCI1 43 #define CLK_BUS_OHCI0 44 #define CLK_BUS_OHCI1 45 #define CLK_BUS_VE 46 #define CLK_BUS_TCON0 47 #define CLK_BUS_TCON1 48 #define CLK_BUS_DEINTERLACE 49 #define CLK_BUS_CSI 50 #define CLK_BUS_HDMI 51 #define CLK_BUS_DE 52 #define CLK_BUS_GPU 53 #define CLK_BUS_MSGBOX 54 #define CLK_BUS_SPINLOCK 55 #define CLK_BUS_CODEC 56 #define CLK_BUS_SPDIF 57 #define CLK_BUS_PIO 58 #define CLK_BUS_THS 59 #define CLK_BUS_I2S0 60 #define CLK_BUS_I2S1 61 #define CLK_BUS_I2S2 62 #define CLK_BUS_I2C0 63 #define CLK_BUS_I2C1 64 #define CLK_BUS_I2C2 65 #define CLK_BUS_SCR 66 #define CLK_BUS_UART0 67 #define CLK_BUS_UART1 68 #define CLK_BUS_UART2 69 #define CLK_BUS_UART3 70 #define CLK_BUS_UART4 71 #define CLK_BUS_DBG 72 #define CLK_THS 73 #define CLK_NAND 74 #define CLK_MMC0 75 #define CLK_MMC1 76 #define CLK_MMC2 77 #define CLK_TS 78 #define CLK_CE 79 #define CLK_SPI0 80 #define CLK_SPI1 81 #define CLK_I2S0 82 #define CLK_I2S1 83 #define CLK_I2S2 84 #define CLK_SPDIF 85 #define CLK_USB_PHY0 86 #define CLK_USB_PHY1 87 #define CLK_USB_HSIC 88 #define CLK_USB_HSIC_12M 89 #define CLK_USB_OHCI0 91 #define CLK_USB_OHCI1 93 #define CLK_DRAM_VE 95 #define CLK_DRAM_CSI 96 #define CLK_DRAM_DEINTERLACE 97 #define CLK_DRAM_TS 98 #define CLK_DE 99 #define CLK_TCON0 100 #define CLK_TCON1 101 #define CLK_DEINTERLACE 102 #define CLK_CSI_MISC 103 #define CLK_CSI_SCLK 104 #define CLK_CSI_MCLK 105 #define CLK_VE 106 #define CLK_AC_DIG 107 #define CLK_AC_DIG_4X 108 #define CLK_AVS 109 #define CLK_HDMI 110 #define CLK_HDMI_DDC 111 #define CLK_DSI_DPHY 113 #define CLK_GPU 114 #endif /* _DT_BINDINGS_CLK_SUN50I_H_ */ his.form.submit();'>mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /include/trace/events/target.h
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/trace/events/target.h')