/* * Copyright (c) 2012-2014, The Linux Foundation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and * only version 2 as published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ #ifndef _DT_BINDINGS_QCOM_SPMI_VADC_H #define _DT_BINDINGS_QCOM_SPMI_VADC_H /* Voltage ADC channels */ #define VADC_USBIN 0x00 #define VADC_DCIN 0x01 #define VADC_VCHG_SNS 0x02 #define VADC_SPARE1_03 0x03 #define VADC_USB_ID_MV 0x04 #define VADC_VCOIN 0x05 #define VADC_VBAT_SNS 0x06 #define VADC_VSYS 0x07 #define VADC_DIE_TEMP 0x08 #define VADC_REF_625MV 0x09 #define VADC_REF_1250MV 0x0a #define VADC_CHG_TEMP 0x0b #define VADC_SPARE1 0x0c #define VADC_SPARE2 0x0d #define VADC_GND_REF 0x0e #define VADC_VDD_VADC 0x0f #define VADC_P_MUX1_1_1 0x10 #define VADC_P_MUX2_1_1 0x11 #define VADC_P_MUX3_1_1 0x12 #define VADC_P_MUX4_1_1 0x13 #define VADC_P_MUX5_1_1 0x14 #define VADC_P_MUX6_1_1 0x15 #define VADC_P_MUX7_1_1 0x16 #define VADC_P_MUX8_1_1 0x17 #define VADC_P_MUX9_1_1 0x18 #define VADC_P_MUX10_1_1 0x19 #define VADC_P_MUX11_1_1 0x1a #define VADC_P_MUX12_1_1 0x1b #define VADC_P_MUX13_1_1 0x1c #define VADC_P_MUX14_1_1 0x1d #define VADC_P_MUX15_1_1 0x1e #define VADC_P_MUX16_1_1 0x1f #define VADC_P_MUX1_1_3 0x20 #define VADC_P_MUX2_1_3 0x21 #define VADC_P_MUX3_1_3 0x22 #define VADC_P_MUX4_1_3 0x23 #define VADC_P_MUX5_1_3 0x24 #define VADC_P_MUX6_1_3 0x25 #define VADC_P_MUX7_1_3 0x26 #define VADC_P_MUX8_1_3 0x27 #define VADC_P_MUX9_1_3 0x28 #define VADC_P_MUX10_1_3 0x29 #define VADC_P_MUX11_1_3 0x2a #define VADC_P_MUX12_1_3 0x2b #define VADC_P_MUX13_1_3 0x2c #define VADC_P_MUX14_1_3 0x2d #define VADC_P_MUX15_1_3 0x2e #define VADC_P_MUX16_1_3 0x2f #define VADC_LR_MUX1_BAT_THERM 0x30 #define VADC_LR_MUX2_BAT_ID 0x31 #define VADC_LR_MUX3_XO_THERM 0x32 #define VADC_LR_MUX4_AMUX_THM1 0x33 #define VADC_LR_MUX5_AMUX_THM2 0x34 #define VADC_LR_MUX6_AMUX_THM3 0x35 #define VADC_LR_MUX7_HW_ID 0x36 #define VADC_LR_MUX8_AMUX_THM4 0x37 #define VADC_LR_MUX9_AMUX_THM5 0x38 #define VADC_LR_MUX10_USB_ID 0x39 #define VADC_AMUX_PU1 0x3a #define VADC_AMUX_PU2 0x3b #define VADC_LR_MUX3_BUF_XO_THERM 0x3c #define VADC_LR_MUX1_PU1_BAT_THERM 0x70 #define VADC_LR_MUX2_PU1_BAT_ID 0x71 #define VADC_LR_MUX3_PU1_XO_THERM 0x72 #define VADC_LR_MUX4_PU1_AMUX_THM1 0x73 #define VADC_LR_MUX5_PU1_AMUX_THM2 0x74 #define VADC_LR_MUX6_PU1_AMUX_THM3 0x75 #define VADC_LR_MUX7_PU1_AMUX_HW_ID 0x76 #define VADC_LR_MUX8_PU1_AMUX_THM4 0x77 #define VADC_LR_MUX9_PU1_AMUX_THM5 0x78 #define VADC_LR_MUX10_PU1_AMUX_USB_ID 0x79 #define VADC_LR_MUX3_BUF_PU1_XO_THERM 0x7c #define VADC_LR_MUX1_PU2_BAT_THERM 0xb0 #define VADC_LR_MUX2_PU2_BAT_ID 0xb1 #define VADC_LR_MUX3_PU2_XO_THERM 0xb2 #define VADC_LR_MUX4_PU2_AMUX_THM1 0xb3 #define VADC_LR_MUX5_PU2_AMUX_THM2 0xb4 #define VADC_LR_MUX6_PU2_AMUX_THM3 0xb5 #define VADC_LR_MUX7_PU2_AMUX_HW_ID 0xb6 #define VADC_LR_MUX8_PU2_AMUX_THM4 0xb7 #define VADC_LR_MUX9_PU2_AMUX_THM5 0xb8 #define VADC_LR_MUX10_PU2_AMUX_USB_ID 0xb9 #define VADC_LR_MUX3_BUF_PU2_XO_THERM 0xbc #define VADC_LR_MUX1_PU1_PU2_BAT_THERM 0xf0 #define VADC_LR_MUX2_PU1_PU2_BAT_ID 0xf1 #define VADC_LR_MUX3_PU1_PU2_XO_THERM 0xf2 #define VADC_LR_MUX4_PU1_PU2_AMUX_THM1 0xf3 #define VADC_LR_MUX5_PU1_PU2_AMUX_THM2 0xf4 #define VADC_LR_MUX6_PU1_PU2_AMUX_THM3 0xf5 #define VADC_LR_MUX7_PU1_PU2_AMUX_HW_ID 0xf6 #define VADC_LR_MUX8_PU1_PU2_AMUX_THM4 0xf7 #define VADC_LR_MUX9_PU1_PU2_AMUX_THM5 0xf8 #define VADC_LR_MUX10_PU1_PU2_AMUX_USB_ID 0xf9 #define VADC_LR_MUX3_BUF_PU1_PU2_XO_THERM 0xfc #endif /* _DT_BINDINGS_QCOM_SPMI_VADC_H */ ct>space:mode:
authorLuis R. Rodriguez <mcgrof@kernel.org>2017-01-25 10:31:52 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-01-27 09:19:48 +0100
commit191e885a2e130e639bb0c8ee350d7047294f2ce6 (patch)
tree9bf9f9b4971df55a46e0a6750d3f6cd37bf1d9f0 /sound/soc/codecs/cs42l56.h
parent49def1853334396f948dcb4cedb9347abb318df5 (diff)
firmware: fix NULL pointer dereference in __fw_load_abort()
Since commit 5d47ec02c37ea6 ("firmware: Correct handling of fw_state_wait() return value") fw_load_abort() could be called twice and lead us to a kernel crash. This happens only when the firmware fallback mechanism (regular or custom) is used. The fallback mechanism exposes a sysfs interface for userspace to upload a file and notify the kernel when the file is loaded and ready, or to cancel an upload by echo'ing -1 into on the loading file: echo -n "-1" > /sys/$DEVPATH/loading This will call fw_load_abort(). Some distributions actually have a udev rule in place to *always* immediately cancel all firmware fallback mechanism requests (Debian), they have: $ cat /lib/udev/rules.d/50-firmware.rules # stub for immediately telling the kernel that userspace firmware loading # failed; necessary to avoid long timeouts with CONFIG_FW_LOADER_USER_HELPER=y SUBSYSTEM=="firmware", ACTION=="add", ATTR{loading}="-1 Distributions with this udev rule would run into this crash only if the fallback mechanism is used. Since most distributions disable by default using the fallback mechanism (CONFIG_FW_LOADER_USER_HELPER_FALLBACK), this would typicaly mean only 2 drivers which *require* the fallback mechanism could typically incur a crash: drivers/firmware/dell_rbu.c and the drivers/leds/leds-lp55xx-common.c driver. Distributions enabling CONFIG_FW_LOADER_USER_HELPER_FALLBACK by default are obviously more exposed to this crash. The crash happens because after commit 5b029624948d ("firmware: do not use fw_lock for fw_state protection") and subsequent fix commit 5d47ec02c37ea6 ("firmware: Correct handling of fw_state_wait() return value") a race can happen between this cancelation and the firmware fw_state_wait_timeout() being woken up after a state change with which fw_load_abort() as that calls swake_up(). Upon error fw_state_wait_timeout() will also again call fw_load_abort() and trigger a null reference. At first glance we could just fix this with a !buf check on fw_load_abort() before accessing buf->fw_st, however there is a logical issue in having a state machine used for the fallback mechanism and preventing access from it once we abort as its inside the buf (buf->fw_st). The firmware_class.c code is setting the buf to NULL to annotate an abort has occurred. Replace this mechanism by simply using the state check instead. All the other code in place already uses similar checks for aborting as well so no further changes are needed. An oops can be reproduced with the new fw_fallback.sh fallback mechanism cancellation test. Either cancelling the fallback mechanism or the custom fallback mechanism triggers a crash. mcgrof@piggy ~/linux-next/tools/testing/selftests/firmware (git::20170111-fw-fixes)$ sudo ./fw_fallback.sh ./fw_fallback.sh: timeout works ./fw_fallback.sh: firmware comparison works ./fw_fallback.sh: fallback mechanism works [ this then sits here when it is trying the cancellation test ] Kernel log: test_firmware: loading 'nope-test-firmware.bin' misc test_firmware: Direct firmware load for nope-test-firmware.bin failed with error -2 misc test_firmware: Falling back to user helper BUG: unable to handle kernel NULL pointer dereference at 0000000000000038 IP: _request_firmware+0xa27/0xad0 PGD 0 Oops: 0000 [#1] SMP Modules linked in: test_firmware(E) ... etc ... CPU: 1 PID: 1396 Comm: fw_fallback.sh Tainted: G W E 4.10.0-rc3-next-20170111+ #30 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.10.1-0-g8891697-prebuilt.qemu-project.org 04/01/2014 task: ffff9740b27f4340 task.stack: ffffbb15c0bc8000 RIP: 0010:_request_firmware+0xa27/0xad0 RSP: 0018:ffffbb15c0bcbd10 EFLAGS: 00010246 RAX: 00000000fffffffe RBX: ffff9740afe5aa80 RCX: 0000000000000000 RDX: ffff9740b27f4340 RSI: 0000000000000283 RDI: 0000000000000000 RBP: ffffbb15c0bcbd90 R08: ffffbb15c0bcbcd8 R09: 0000000000000000 R10: 0000000894a0d4b1 R11: 000000000000008c R12: ffffffffc0312480 R13: 0000000000000005 R14: ffff9740b1c32400 R15: 00000000000003e8 FS: 00007f8604422700(0000) GS:ffff9740bfc80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000038 CR3: 000000012164c000 CR4: 00000000000006e0 Call Trace: request_firmware+0x37/0x50 trigger_request_store+0x79/0xd0 [test_firmware] dev_attr_store+0x18/0x30 sysfs_kf_write+0x37/0x40 kernfs_fop_write+0x110/0x1a0 __vfs_write+0x37/0x160 ? _cond_resched+0x1a/0x50 vfs_write+0xb5/0x1a0 SyS_write+0x55/0xc0 ? trace_do_page_fault+0x37/0xd0 entry_SYSCALL_64_fastpath+0x1e/0xad RIP: 0033:0x7f8603f49620 RSP: 002b:00007fff6287b788 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 000055c307b110a0 RCX: 00007f8603f49620 RDX: 0000000000000016 RSI: 000055c3084d8a90 RDI: 0000000000000001 RBP: 0000000000000016 R08: 000000000000c0ff R09: 000055c3084d6336 R10: 000055c307b108b0 R11: 0000000000000246 R12: 000055c307b13c80 R13: 000055c3084d6320 R14: 0000000000000000 R15: 00007fff6287b950 Code: 9f 64 84 e8 9c 61 fe ff b8 f4 ff ff ff e9 6b f9 ff ff 48 c7 c7 40 6b 8d 84 89 45 a8 e8 43 84 18 00 49 8b be 00 03 00 00 8b 45 a8 <83> 7f 38 02 74 08 e8 6e ec ff ff 8b 45 a8 49 c7 86 00 03 00 00 RIP: _request_firmware+0xa27/0xad0 RSP: ffffbb15c0bcbd10 CR2: 0000000000000038 ---[ end trace 6d94ac339c133e6f ]--- Fixes: 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() return value") Reported-and-Tested-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reported-and-Tested-by: Patrick Bruenn <p.bruenn@beckhoff.com> Reported-by: Chris Wilson <chris@chris-wilson.co.uk> CC: <stable@vger.kernel.org> [3.10+] Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/soc/codecs/cs42l56.h')