/* * This header provides macros for ams AS3722 device bindings. * * Copyright (c) 2013, NVIDIA Corporation. * * Author: Laxman Dewangan * */ #ifndef __DT_BINDINGS_AS3722_H__ #define __DT_BINDINGS_AS3722_H__ /* External control pins */ #define AS3722_EXT_CONTROL_PIN_ENABLE1 1 #define AS3722_EXT_CONTROL_PIN_ENABLE2 2 #define AS3722_EXT_CONTROL_PIN_ENABLE3 3 /* Interrupt numbers for AS3722 */ #define AS3722_IRQ_LID 0 #define AS3722_IRQ_ACOK 1 #define AS3722_IRQ_ENABLE1 2 #define AS3722_IRQ_OCCUR_ALARM_SD0 3 #define AS3722_IRQ_ONKEY_LONG_PRESS 4 #define AS3722_IRQ_ONKEY 5 #define AS3722_IRQ_OVTMP 6 #define AS3722_IRQ_LOWBAT 7 #define AS3722_IRQ_SD0_LV 8 #define AS3722_IRQ_SD1_LV 9 #define AS3722_IRQ_SD2_LV 10 #define AS3722_IRQ_PWM1_OV_PROT 11 #define AS3722_IRQ_PWM2_OV_PROT 12 #define AS3722_IRQ_ENABLE2 13 #define AS3722_IRQ_SD6_LV 14 #define AS3722_IRQ_RTC_REP 15 #define AS3722_IRQ_RTC_ALARM 16 #define AS3722_IRQ_GPIO1 17 #define AS3722_IRQ_GPIO2 18 #define AS3722_IRQ_GPIO3 19 #define AS3722_IRQ_GPIO4 20 #define AS3722_IRQ_GPIO5 21 #define AS3722_IRQ_WATCHDOG 22 #define AS3722_IRQ_ENABLE3 23 #define AS3722_IRQ_TEMP_SD0_SHUTDOWN 24 #define AS3722_IRQ_TEMP_SD1_SHUTDOWN 25 #define AS3722_IRQ_TEMP_SD2_SHUTDOWN 26 #define AS3722_IRQ_TEMP_SD0_ALARM 27 #define AS3722_IRQ_TEMP_SD1_ALARM 28 #define AS3722_IRQ_TEMP_SD6_ALARM 29 #define AS3722_IRQ_OCCUR_ALARM_SD6 30 #define AS3722_IRQ_ADC 31 #endif /* __DT_BINDINGS_AS3722_H__ */ auser
summaryrefslogtreecommitdiff
path: root/include/dt-bindings/mailbox/tegra186-hsp.h
5'>5
AgeCommit message (Expand)AuthorFilesLines
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /net/bluetooth/hidp/Kconfig
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'net/bluetooth/hidp/Kconfig')