/* * This header provides macros for MAXIM MAX77620 device bindings. * * Copyright (c) 2016, NVIDIA Corporation. * Author: Laxman Dewangan */ #ifndef _DT_BINDINGS_MFD_MAX77620_H #define _DT_BINDINGS_MFD_MAX77620_H /* MAX77620 interrupts */ #define MAX77620_IRQ_TOP_GLBL 0 /* Low-Battery */ #define MAX77620_IRQ_TOP_SD 1 /* SD power fail */ #define MAX77620_IRQ_TOP_LDO 2 /* LDO power fail */ #define MAX77620_IRQ_TOP_GPIO 3 /* GPIO internal int to MAX77620 */ #define MAX77620_IRQ_TOP_RTC 4 /* RTC */ #define MAX77620_IRQ_TOP_32K 5 /* 32kHz oscillator */ #define MAX77620_IRQ_TOP_ONOFF 6 /* ON/OFF oscillator */ #define MAX77620_IRQ_LBT_MBATLOW 7 /* Thermal alarm status, > 120C */ #define MAX77620_IRQ_LBT_TJALRM1 8 /* Thermal alarm status, > 120C */ #define MAX77620_IRQ_LBT_TJALRM2 9 /* Thermal alarm status, > 140C */ /* FPS event source */ #define MAX77620_FPS_EVENT_SRC_EN0 0 #define MAX77620_FPS_EVENT_SRC_EN1 1 #define MAX77620_FPS_EVENT_SRC_SW 2 /* Device state when FPS event LOW */ #define MAX77620_FPS_INACTIVE_STATE_SLEEP 0 #define MAX77620_FPS_INACTIVE_STATE_LOW_POWER 1 /* FPS source */ #define MAX77620_FPS_SRC_0 0 #define MAX77620_FPS_SRC_1 1 #define MAX77620_FPS_SRC_2 2 #define MAX77620_FPS_SRC_NONE 3 #define MAX77620_FPS_SRC_DEF 4 #endif mp-back'>packet-rx-pump-back net-next plumbingsTobias Klauser
summaryrefslogtreecommitdiff
path: root/drivers/usb/gadget/udc/fusb300_udc.h
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /drivers/usb/gadget/udc/fusb300_udc.h
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'drivers/usb/gadget/udc/fusb300_udc.h')