/* * Copyright (c) 2014, Steffen Trumtrar * * This software is licensed under the terms of the GNU General Public * License version 2, as published by the Free Software Foundation, and * may be copied, distributed, and modified under those terms. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ #ifndef _DT_BINDINGS_RESET_ALTR_RST_MGR_A10_H #define _DT_BINDINGS_RESET_ALTR_RST_MGR_A10_H /* MPUMODRST */ #define CPU0_RESET 0 #define CPU1_RESET 1 #define WDS_RESET 2 #define SCUPER_RESET 3 /* PER0MODRST */ #define EMAC0_RESET 32 #define EMAC1_RESET 33 #define EMAC2_RESET 34 #define USB0_RESET 35 #define USB1_RESET 36 #define NAND_RESET 37 #define QSPI_RESET 38 #define SDMMC_RESET 39 #define EMAC0_OCP_RESET 40 #define EMAC1_OCP_RESET 41 #define EMAC2_OCP_RESET 42 #define USB0_OCP_RESET 43 #define USB1_OCP_RESET 44 #define NAND_OCP_RESET 45 #define QSPI_OCP_RESET 46 #define SDMMC_OCP_RESET 47 #define DMA_RESET 48 #define SPIM0_RESET 49 #define SPIM1_RESET 50 #define SPIS0_RESET 51 #define SPIS1_RESET 52 #define DMA_OCP_RESET 53 #define EMAC_PTP_RESET 54 /* 55 is empty*/ #define DMAIF0_RESET 56 #define DMAIF1_RESET 57 #define DMAIF2_RESET 58 #define DMAIF3_RESET 59 #define DMAIF4_RESET 60 #define DMAIF5_RESET 61 #define DMAIF6_RESET 62 #define DMAIF7_RESET 63 /* PER1MODRST */ #define L4WD0_RESET 64 #define L4WD1_RESET 65 #define L4SYSTIMER0_RESET 66 #define L4SYSTIMER1_RESET 67 #define SPTIMER0_RESET 68 #define SPTIMER1_RESET 69 /* 70-71 is reserved */ #define I2C0_RESET 72 #define I2C1_RESET 73 #define I2C2_RESET 74 #define I2C3_RESET 75 #define I2C4_RESET 76 /* 77-79 is reserved */ #define UART0_RESET 80 #define UART1_RESET 81 /* 82-87 is reserved */ #define GPIO0_RESET 88 #define GPIO1_RESET 89 #define GPIO2_RESET 90 /* BRGMODRST */ #define HPS2FPGA_RESET 96 #define LWHPS2FPGA_RESET 97 #define FPGA2HPS_RESET 98 #define F2SSDRAM0_RESET 99 #define F2SSDRAM1_RESET 100 #define F2SSDRAM2_RESET 101 #define DDRSCH_RESET 102 /* SYSMODRST*/ #define ROM_RESET 128 #define OCRAM_RESET 129 /* 130 is reserved */ #define FPGAMGR_RESET 131 #define S2F_RESET 132 #define SYSDBG_RESET 133 #define OCRAM_OCP_RESET 134 /* COLDMODRST */ #define CLKMGRCOLD_RESET 160 /* 161-162 is reserved */ #define S2FCOLD_RESET 163 #define TIMESTAMPCOLD_RESET 164 #define TAPCOLD_RESET 165 #define HMCCOLD_RESET 166 #define IOMGRCOLD_RESET 167 /* NRSTMODRST */ #define NRSTPINOE_RESET 192 /* DBGMODRST */ #define DBG_RESET 224 #endif /linux/net-next.git/commit/?id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>root/drivers/usb/serial/cypress_m8.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /drivers/usb/serial/cypress_m8.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/usb/serial/cypress_m8.c')