/* * Copyright (c) 2014, The Linux Foundation. All rights reserved. * * This software is licensed under the terms of the GNU General Public * License version 2, as published by the Free Software Foundation, and * may be copied, distributed, and modified under those terms. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. */ #ifndef _DT_BINDINGS_RESET_APQ_MMCC_8084_H #define _DT_BINDINGS_RESET_APQ_MMCC_8084_H #define MMSS_SPDM_RESET 0 #define MMSS_SPDM_RM_RESET 1 #define VENUS0_RESET 2 #define VPU_RESET 3 #define MDSS_RESET 4 #define AVSYNC_RESET 5 #define CAMSS_PHY0_RESET 6 #define CAMSS_PHY1_RESET 7 #define CAMSS_PHY2_RESET 8 #define CAMSS_CSI0_RESET 9 #define CAMSS_CSI0PHY_RESET 10 #define CAMSS_CSI0RDI_RESET 11 #define CAMSS_CSI0PIX_RESET 12 #define CAMSS_CSI1_RESET 13 #define CAMSS_CSI1PHY_RESET 14 #define CAMSS_CSI1RDI_RESET 15 #define CAMSS_CSI1PIX_RESET 16 #define CAMSS_CSI2_RESET 17 #define CAMSS_CSI2PHY_RESET 18 #define CAMSS_CSI2RDI_RESET 19 #define CAMSS_CSI2PIX_RESET 20 #define CAMSS_CSI3_RESET 21 #define CAMSS_CSI3PHY_RESET 22 #define CAMSS_CSI3RDI_RESET 23 #define CAMSS_CSI3PIX_RESET 24 #define CAMSS_ISPIF_RESET 25 #define CAMSS_CCI_RESET 26 #define CAMSS_MCLK0_RESET 27 #define CAMSS_MCLK1_RESET 28 #define CAMSS_MCLK2_RESET 29 #define CAMSS_MCLK3_RESET 30 #define CAMSS_GP0_RESET 31 #define CAMSS_GP1_RESET 32 #define CAMSS_TOP_RESET 33 #define CAMSS_AHB_RESET 34 #define CAMSS_MICRO_RESET 35 #define CAMSS_JPEG_RESET 36 #define CAMSS_VFE_RESET 37 #define CAMSS_CSI_VFE0_RESET 38 #define CAMSS_CSI_VFE1_RESET 39 #define OXILI_RESET 40 #define OXILICX_RESET 41 #define OCMEMCX_RESET 42 #define MMSS_RBCRP_RESET 43 #define MMSSNOCAHB_RESET 44 #define MMSSNOCAXI_RESET 45 #endif id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>commitdiff
path: root/drivers/usb/gadget/udc/core.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /drivers/usb/gadget/udc/core.c
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/usb/gadget/udc/core.c')