/* * This header provides constants for the reset controller * based peripheral powerdown requests on the STMicroelectronics * STiH407 SoC. */ #ifndef _DT_BINDINGS_RESET_CONTROLLER_STIH407 #define _DT_BINDINGS_RESET_CONTROLLER_STIH407 /* Powerdown requests control 0 */ #define STIH407_EMISS_POWERDOWN 0 #define STIH407_NAND_POWERDOWN 1 /* Synp GMAC PowerDown */ #define STIH407_ETH1_POWERDOWN 2 /* Powerdown requests control 1 */ #define STIH407_USB3_POWERDOWN 3 #define STIH407_USB2_PORT1_POWERDOWN 4 #define STIH407_USB2_PORT0_POWERDOWN 5 #define STIH407_PCIE1_POWERDOWN 6 #define STIH407_PCIE0_POWERDOWN 7 #define STIH407_SATA1_POWERDOWN 8 #define STIH407_SATA0_POWERDOWN 9 /* Reset defines */ #define STIH407_ETH1_SOFTRESET 0 #define STIH407_MMC1_SOFTRESET 1 #define STIH407_PICOPHY_SOFTRESET 2 #define STIH407_IRB_SOFTRESET 3 #define STIH407_PCIE0_SOFTRESET 4 #define STIH407_PCIE1_SOFTRESET 5 #define STIH407_SATA0_SOFTRESET 6 #define STIH407_SATA1_SOFTRESET 7 #define STIH407_MIPHY0_SOFTRESET 8 #define STIH407_MIPHY1_SOFTRESET 9 #define STIH407_MIPHY2_SOFTRESET 10 #define STIH407_SATA0_PWR_SOFTRESET 11 #define STIH407_SATA1_PWR_SOFTRESET 12 #define STIH407_DELTA_SOFTRESET 13 #define STIH407_BLITTER_SOFTRESET 14 #define STIH407_HDTVOUT_SOFTRESET 15 #define STIH407_HDQVDP_SOFTRESET 16 #define STIH407_VDP_AUX_SOFTRESET 17 #define STIH407_COMPO_SOFTRESET 18 #define STIH407_HDMI_TX_PHY_SOFTRESET 19 #define STIH407_JPEG_DEC_SOFTRESET 20 #define STIH407_VP8_DEC_SOFTRESET 21 #define STIH407_GPU_SOFTRESET 22 #define STIH407_HVA_SOFTRESET 23 #define STIH407_ERAM_HVA_SOFTRESET 24 #define STIH407_LPM_SOFTRESET 25 #define STIH407_KEYSCAN_SOFTRESET 26 #define STIH407_USB2_PORT0_SOFTRESET 27 #define STIH407_USB2_PORT1_SOFTRESET 28 #define STIH407_ST231_AUD_SOFTRESET 29 #define STIH407_ST231_DMU_SOFTRESET 30 #define STIH407_ST231_GP0_SOFTRESET 31 #define STIH407_ST231_GP1_SOFTRESET 32 /* Picophy reset defines */ #define STIH407_PICOPHY0_RESET 0 #define STIH407_PICOPHY1_RESET 1 #define STIH407_PICOPHY2_RESET 2 #endif /* _DT_BINDINGS_RESET_CONTROLLER_STIH407 */ 8eef542c5414e54bf1a'>diff
path: root/sound/pci/hda/patch_analog.c
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /sound/pci/hda/patch_analog.c
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'sound/pci/hda/patch_analog.c')