/* * Copyright (C) 2016 Maxime Ripard * * This file is dual-licensed: you can use it either under the terms * of the GPL or the X11 license, at your option. Note that this dual * licensing only applies to this file, and not this project as a * whole. * * a) This file is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License as * published by the Free Software Foundation; either version 2 of the * License, or (at your option) any later version. * * This file is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * Or, alternatively, * * b) Permission is hereby granted, free of charge, to any person * obtaining a copy of this software and associated documentation * files (the "Software"), to deal in the Software without * restriction, including without limitation the rights to use, * copy, modify, merge, publish, distribute, sublicense, and/or * sell copies of the Software, and to permit persons to whom the * Software is furnished to do so, subject to the following * conditions: * * The above copyright notice and this permission notice shall be * included in all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR * OTHER DEALINGS IN THE SOFTWARE. */ #ifndef _DT_BINDINGS_RST_SUN8I_H3_H_ #define _DT_BINDINGS_RST_SUN8I_H3_H_ #define RST_USB_PHY0 0 #define RST_USB_PHY1 1 #define RST_USB_PHY2 2 #define RST_USB_PHY3 3 #define RST_MBUS 4 #define RST_BUS_CE 5 #define RST_BUS_DMA 6 #define RST_BUS_MMC0 7 #define RST_BUS_MMC1 8 #define RST_BUS_MMC2 9 #define RST_BUS_NAND 10 #define RST_BUS_DRAM 11 #define RST_BUS_EMAC 12 #define RST_BUS_TS 13 #define RST_BUS_HSTIMER 14 #define RST_BUS_SPI0 15 #define RST_BUS_SPI1 16 #define RST_BUS_OTG 17 #define RST_BUS_EHCI0 18 #define RST_BUS_EHCI1 19 #define RST_BUS_EHCI2 20 #define RST_BUS_EHCI3 21 #define RST_BUS_OHCI0 22 #define RST_BUS_OHCI1 23 #define RST_BUS_OHCI2 24 #define RST_BUS_OHCI3 25 #define RST_BUS_VE 26 #define RST_BUS_TCON0 27 #define RST_BUS_TCON1 28 #define RST_BUS_DEINTERLACE 29 #define RST_BUS_CSI 30 #define RST_BUS_TVE 31 #define RST_BUS_HDMI0 32 #define RST_BUS_HDMI1 33 #define RST_BUS_DE 34 #define RST_BUS_GPU 35 #define RST_BUS_MSGBOX 36 #define RST_BUS_SPINLOCK 37 #define RST_BUS_DBG 38 #define RST_BUS_EPHY 39 #define RST_BUS_CODEC 40 #define RST_BUS_SPDIF 41 #define RST_BUS_THS 42 #define RST_BUS_I2S0 43 #define RST_BUS_I2S1 44 #define RST_BUS_I2S2 45 #define RST_BUS_I2C0 46 #define RST_BUS_I2C1 47 #define RST_BUS_I2C2 48 #define RST_BUS_UART0 49 #define RST_BUS_UART1 50 #define RST_BUS_UART2 51 #define RST_BUS_UART3 52 #define RST_BUS_SCR 53 #endif /* _DT_BINDINGS_RST_SUN8I_H3_H_ */ space:mode:

author	Iago Abal <mail@iagoabal.eu>	2017-01-11 14:00:21 +0100
committer	Vinod Koul <vinod.koul@intel.com>	2017-01-25 15:35:11 +0530
commit	91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree	960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include
parent	6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)

dmaengine: pl330: fix double lock

The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Diffstat (limited to 'include')