/* cx25840.h - definition for cx25840/1/2/3 inputs Copyright (C) 2006 Hans Verkuil (hverkuil@xs4all.nl) This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #ifndef _CX25840_H_ #define _CX25840_H_ /* Note that the cx25840 driver requires that the bridge driver calls the v4l2_subdev's init operation in order to load the driver's firmware. Without this the audio standard detection will fail and you will only get mono. Since loading the firmware is often problematic when the driver is compiled into the kernel I recommend postponing calling this function until the first open of the video device. Another reason for postponing it is that loading this firmware takes a long time (seconds) due to the slow i2c bus speed. So it will speed up the boot process if you can avoid loading the fw as long as the video device isn't used. */ enum cx25840_video_input { /* Composite video inputs In1-In8 */ CX25840_COMPOSITE1 = 1, CX25840_COMPOSITE2, CX25840_COMPOSITE3, CX25840_COMPOSITE4, CX25840_COMPOSITE5, CX25840_COMPOSITE6, CX25840_COMPOSITE7, CX25840_COMPOSITE8, /* S-Video inputs consist of one luma input (In1-In8) ORed with one chroma input (In5-In8) */ CX25840_SVIDEO_LUMA1 = 0x10, CX25840_SVIDEO_LUMA2 = 0x20, CX25840_SVIDEO_LUMA3 = 0x30, CX25840_SVIDEO_LUMA4 = 0x40, CX25840_SVIDEO_LUMA5 = 0x50, CX25840_SVIDEO_LUMA6 = 0x60, CX25840_SVIDEO_LUMA7 = 0x70, CX25840_SVIDEO_LUMA8 = 0x80, CX25840_SVIDEO_CHROMA4 = 0x400, CX25840_SVIDEO_CHROMA5 = 0x500, CX25840_SVIDEO_CHROMA6 = 0x600, CX25840_SVIDEO_CHROMA7 = 0x700, CX25840_SVIDEO_CHROMA8 = 0x800, /* S-Video aliases for common luma/chroma combinations */ CX25840_SVIDEO1 = 0x510, CX25840_SVIDEO2 = 0x620, CX25840_SVIDEO3 = 0x730, CX25840_SVIDEO4 = 0x840, /* Allow frames to specify specific input configurations */ CX25840_VIN1_CH1 = 0x80000000, CX25840_VIN2_CH1 = 0x80000001, CX25840_VIN3_CH1 = 0x80000002, CX25840_VIN4_CH1 = 0x80000003, CX25840_VIN5_CH1 = 0x80000004, CX25840_VIN6_CH1 = 0x80000005, CX25840_VIN7_CH1 = 0x80000006, CX25840_VIN8_CH1 = 0x80000007, CX25840_VIN4_CH2 = 0x80000000, CX25840_VIN5_CH2 = 0x80000010, CX25840_VIN6_CH2 = 0x80000020, CX25840_NONE_CH2 = 0x80000030, CX25840_VIN7_CH3 = 0x80000000, CX25840_VIN8_CH3 = 0x80000040, CX25840_NONE0_CH3 = 0x80000080, CX25840_NONE1_CH3 = 0x800000c0, CX25840_SVIDEO_ON = 0x80000100, CX25840_COMPONENT_ON = 0x80000200, CX25840_DIF_ON = 0x80000400, }; enum cx25840_audio_input { /* Audio inputs: serial or In4-In8 */ CX25840_AUDIO_SERIAL, CX25840_AUDIO4 = 4, CX25840_AUDIO5, CX25840_AUDIO6, CX25840_AUDIO7, CX25840_AUDIO8, }; enum cx25840_io_pin { CX25840_PIN_DVALID_PRGM0 = 0, CX25840_PIN_FIELD_PRGM1, CX25840_PIN_HRESET_PRGM2, CX25840_PIN_VRESET_HCTL_PRGM3, CX25840_PIN_IRQ_N_PRGM4, CX25840_PIN_IR_TX_PRGM6, CX25840_PIN_IR_RX_PRGM5, CX25840_PIN_GPIO0_PRGM8, CX25840_PIN_GPIO1_PRGM9, CX25840_PIN_SA_SDIN, /* Alternate GP Input only */ CX25840_PIN_SA_SDOUT, /* Alternate GP Input only */ CX25840_PIN_PLL_CLK_PRGM7, CX25840_PIN_CHIP_SEL_VIPCLK, /* Output only */ }; enum cx25840_io_pad { /* Output pads */ CX25840_PAD_DEFAULT = 0, CX25840_PAD_ACTIVE, CX25840_PAD_VACTIVE, CX25840_PAD_CBFLAG, CX25840_PAD_VID_DATA_EXT0, CX25840_PAD_VID_DATA_EXT1, CX25840_PAD_GPO0, CX25840_PAD_GPO1, CX25840_PAD_GPO2, CX25840_PAD_GPO3, CX25840_PAD_IRQ_N, CX25840_PAD_AC_SYNC, CX25840_PAD_AC_SDOUT, CX25840_PAD_PLL_CLK, CX25840_PAD_VRESET, CX25840_PAD_RESERVED, /* Pads for PLL_CLK output only */ CX25840_PAD_XTI_X5_DLL, CX25840_PAD_AUX_PLL, CX25840_PAD_VID_PLL, CX25840_PAD_XTI, /* Input Pads */ CX25840_PAD_GPI0, CX25840_PAD_GPI1, CX25840_PAD_GPI2, CX25840_PAD_GPI3, }; enum cx25840_io_pin_strength { CX25840_PIN_DRIVE_MEDIUM = 0, CX25840_PIN_DRIVE_SLOW, CX25840_PIN_DRIVE_FAST, }; enum cx23885_io_pin { CX23885_PIN_IR_RX_GPIO19, CX23885_PIN_IR_TX_GPIO20, CX23885_PIN_I2S_SDAT_GPIO21, CX23885_PIN_I2S_WCLK_GPIO22, CX23885_PIN_I2S_BCLK_GPIO23, CX23885_PIN_IRQ_N_GPIO16, }; enum cx23885_io_pad { CX23885_PAD_IR_RX, CX23885_PAD_GPIO19, CX23885_PAD_IR_TX, CX23885_PAD_GPIO20, CX23885_PAD_I2S_SDAT, CX23885_PAD_GPIO21, CX23885_PAD_I2S_WCLK, CX23885_PAD_GPIO22, CX23885_PAD_I2S_BCLK, CX23885_PAD_GPIO23, CX23885_PAD_IRQ_N, CX23885_PAD_GPIO16, }; /* pvr150_workaround activates a workaround for a hardware bug that is present in Hauppauge PVR-150 (and possibly PVR-500) cards that have certain NTSC tuners (tveeprom tuner model numbers 85, 99 and 112). The audio autodetect fails on some channels for these models and the workaround is to select the audio standard explicitly. Many thanks to Hauppauge for providing this information. This platform data only needs to be supplied by the ivtv driver. */ struct cx25840_platform_data { int pvr150_workaround; }; #endif t.h?id=91539eb1fda2d530d3b268eef542c5414e54bf1a'>patch) tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /include/drm/drm_mode_object.h parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'include/drm/drm_mode_object.h')