/* * adv7183.h - definition for adv7183 inputs and outputs * * Copyright (c) 2011 Analog Devices Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ #ifndef _ADV7183_H_ #define _ADV7183_H_ /* ADV7183 HW inputs */ #define ADV7183_COMPOSITE0 0 /* CVBS in on AIN1 */ #define ADV7183_COMPOSITE1 1 /* CVBS in on AIN2 */ #define ADV7183_COMPOSITE2 2 /* CVBS in on AIN3 */ #define ADV7183_COMPOSITE3 3 /* CVBS in on AIN4 */ #define ADV7183_COMPOSITE4 4 /* CVBS in on AIN5 */ #define ADV7183_COMPOSITE5 5 /* CVBS in on AIN6 */ #define ADV7183_COMPOSITE6 6 /* CVBS in on AIN7 */ #define ADV7183_COMPOSITE7 7 /* CVBS in on AIN8 */ #define ADV7183_COMPOSITE8 8 /* CVBS in on AIN9 */ #define ADV7183_COMPOSITE9 9 /* CVBS in on AIN10 */ #define ADV7183_COMPOSITE10 10 /* CVBS in on AIN11 */ #define ADV7183_SVIDEO0 11 /* Y on AIN1, C on AIN4 */ #define ADV7183_SVIDEO1 12 /* Y on AIN2, C on AIN5 */ #define ADV7183_SVIDEO2 13 /* Y on AIN3, C on AIN6 */ #define ADV7183_COMPONENT0 14 /* Y on AIN1, Pr on AIN4, Pb on AIN5 */ #define ADV7183_COMPONENT1 15 /* Y on AIN2, Pr on AIN3, Pb on AIN6 */ /* ADV7183 HW outputs */ #define ADV7183_8BIT_OUT 0 #define ADV7183_16BIT_OUT 1 #endif vents?h=nds-private-remove'>logtreecommitdiff
path: root/tools/perf/pmu-events
diff options
context:
space:
mode:
authorIago Abal <mail@iagoabal.eu>2017-01-11 14:00:21 +0100
committerVinod Koul <vinod.koul@intel.com>2017-01-25 15:35:11 +0530
commit91539eb1fda2d530d3b268eef542c5414e54bf1a (patch)
tree960f5ca6342ad20837aff18aad6e8ecd7da32fd6 /tools/perf/pmu-events
parent6610d0edf6dc7ee97e46ab3a538a565c79d26199 (diff)
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the following double-lock bug: Double lock: 1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236; 2. call to function `pl330_release_channel' immediately after; 3. call to function `dma_pl330_rqcb' in line 1753; 4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505. I have fixed it as suggested by Marek Szyprowski. First, I have replaced `pch->lock' with `pl330->lock' in functions `pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids the double-lock by acquiring a different lock than `dma_pl330_rqcb'. NOTE that, as a result, `pl330_free_chan_resources' executes `list_splice_tail_init' on `pch->work_list' under lock `pl330->lock', whereas in the rest of the code `pch->work_list' is protected by `pch->lock'. I don't know if this may cause race conditions. Similarly `pch->cyclic' is written by `pl330_alloc_chan_resources' under `pl330->lock' but read by `pl330_tx_submit' under `pch->lock'. Second, I have removed locking from `pl330_request_channel' and `pl330_release_channel' functions. Function `pl330_request_channel' is only called from `pl330_alloc_chan_resources', so the lock is already held. Function `pl330_release_channel' is called from `pl330_free_chan_resources', which already holds the lock, and from `pl330_del'. Function `pl330_del' is called in an error path of `pl330_probe' and at the end of `pl330_remove', but I assume that there cannot be concurrent accesses to the protected data at those points. Signed-off-by: Iago Abal <mail@iagoabal.eu> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Diffstat (limited to 'tools/perf/pmu-events')