/* * tveeprom - Contains structures and functions to work with Hauppauge * eeproms. */ #include /** * enum tveeprom_audio_processor - Specifies the type of audio processor * used on a Hauppauge device. * * @TVEEPROM_AUDPROC_NONE: No audio processor present * @TVEEPROM_AUDPROC_INTERNAL: The audio processor is internal to the * video processor * @TVEEPROM_AUDPROC_MSP: The audio processor is a MSPXXXX device * @TVEEPROM_AUDPROC_OTHER: The audio processor is another device */ enum tveeprom_audio_processor { TVEEPROM_AUDPROC_NONE, TVEEPROM_AUDPROC_INTERNAL, TVEEPROM_AUDPROC_MSP, TVEEPROM_AUDPROC_OTHER, }; /** * struct tveeprom - Contains the fields parsed from Hauppauge eeproms * * @has_radio: 1 if the device has radio; 0 otherwise. * * @has_ir: If has_ir == 0, then it is unknown what the IR * capabilities are. Otherwise: * bit 0) 1 (= IR capabilities are known); * bit 1) IR receiver present; * bit 2) IR transmitter (blaster) present. * * @has_MAC_address: 0: no MAC, 1: MAC present, 2: unknown. * @tuner_type: type of the tuner (TUNER_*, as defined at * include/media/tuner.h). * * @tuner_formats: Supported analog TV standards (V4L2_STD_*). * @tuner_hauppauge_model: Hauppauge's code for the device model number. * @tuner2_type: type of the second tuner (TUNER_*, as defined * at include/media/tuner.h). * * @tuner2_formats: Tuner 2 supported analog TV standards * (V4L2_STD_*). * * @tuner2_hauppauge_model: tuner 2 Hauppauge's code for the device model * number. * * @audio_processor: analog audio decoder, as defined by enum * tveeprom_audio_processor. * * @decoder_processor: Hauppauge's code for the decoder chipset. * Unused by the drivers, as they probe the * decoder based on the PCI or USB ID. * * @model: Hauppauge's model number * * @revision: Card revision number * * @serial_number: Card's serial number * * @rev_str: Card revision converted to number * * @MAC_address: MAC address for the network interface */ struct tveeprom { u32 has_radio; u32 has_ir; u32 has_MAC_address; u32 tuner_type; u32 tuner_formats; u32 tuner_hauppauge_model; u32 tuner2_type; u32 tuner2_formats; u32 tuner2_hauppauge_model; u32 audio_processor; u32 decoder_processor; u32 model; u32 revision; u32 serial_number; char rev_str[5]; u8 MAC_address[ETH_ALEN]; }; /** * tveeprom_hauppauge_analog - Fill struct tveeprom using the contents * of the eeprom previously filled at * @eeprom_data field. * * @c: I2C client struct * @tvee: Struct to where the eeprom parsed data will be filled; * @eeprom_data: Array with the contents of the eeprom_data. It should * contain 256 bytes filled with the contents of the * eeprom read from the Hauppauge device. */ void tveeprom_hauppauge_analog(struct i2c_client *c, struct tveeprom *tvee, unsigned char *eeprom_data); /** * tveeprom_read - Reads the contents of the eeprom found at the Hauppauge * devices. * * @c: I2C client struct * @eedata: Array where the eeprom content will be stored. * @len: Size of @eedata array. If the eeprom content will be latter * be parsed by tveeprom_hauppauge_analog(), len should be, at * least, 256. */ int tveeprom_read(struct i2c_client *c, unsigned char *eedata, int len); /tegra?h=nds-private-remove&id=39cb2c9a316e77f6dfba96c543e55b6672d5a37e'>tegra/common.h
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /include/soc/tegra/common.h
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/soc/tegra/common.h')