/* * Copyright (C) ST-Ericsson AB 2010 * Author: Sjur Brendeland * License terms: GNU General Public License (GPL) version 2 */ #ifndef CAIF_DEV_H_ #define CAIF_DEV_H_ #include #include #include #include #include #include /** * struct caif_param - CAIF parameters. * @size: Length of data * @data: Binary Data Blob */ struct caif_param { u16 size; u8 data[256]; }; /** * struct caif_connect_request - Request data for CAIF channel setup. * @protocol: Type of CAIF protocol to use (at, datagram etc) * @sockaddr: Socket address to connect. * @priority: Priority of the connection. * @link_selector: Link selector (high bandwidth or low latency) * @ifindex: kernel index of the interface. * @param: Connect Request parameters (CAIF_SO_REQ_PARAM). * * This struct is used when connecting a CAIF channel. * It contains all CAIF channel configuration options. */ struct caif_connect_request { enum caif_protocol_type protocol; struct sockaddr_caif sockaddr; enum caif_channel_priority priority; enum caif_link_selector link_selector; int ifindex; struct caif_param param; }; /** * caif_connect_client - Connect a client to CAIF Core Stack. * @config: Channel setup parameters, specifying what address * to connect on the Modem. * @client_layer: User implementation of client layer. This layer * MUST have receive and control callback functions * implemented. * @ifindex: Link layer interface index used for this connection. * @headroom: Head room needed by CAIF protocol. * @tailroom: Tail room needed by CAIF protocol. * * This function connects a CAIF channel. The Client must implement * the struct cflayer. This layer represents the Client layer and holds * receive functions and control callback functions. Control callback * function will receive information about connect/disconnect responses, * flow control etc (see enum caif_control). * E.g. CAIF Socket will call this function for each socket it connects * and have one client_layer instance for each socket. */ int caif_connect_client(struct net *net, struct caif_connect_request *conn_req, struct cflayer *client_layer, int *ifindex, int *headroom, int *tailroom); /** * caif_disconnect_client - Disconnects a client from the CAIF stack. * * @client_layer: Client layer to be disconnected. */ int caif_disconnect_client(struct net *net, struct cflayer *client_layer); /** * caif_client_register_refcnt - register ref-count functions provided by client. * * @adapt_layer: Client layer using CAIF Stack. * @hold: Function provided by client layer increasing ref-count * @put: Function provided by client layer decreasing ref-count * * Client of the CAIF Stack must register functions for reference counting. * These functions are called by the CAIF Stack for every upstream packet, * and must therefore be implemented efficiently. * * Client should call caif_free_client when reference count degrease to zero. */ void caif_client_register_refcnt(struct cflayer *adapt_layer, void (*hold)(struct cflayer *lyr), void (*put)(struct cflayer *lyr)); /** * caif_free_client - Free memory used to manage the client in the CAIF Stack. * * @client_layer: Client layer to be removed. * * This function must be called from client layer in order to free memory. * Caller must guarantee that no packets are in flight upstream when calling * this function. */ void caif_free_client(struct cflayer *adap_layer); /** * struct caif_enroll_dev - Enroll a net-device as a CAIF Link layer * @dev: Network device to enroll. * @caifdev: Configuration information from CAIF Link Layer * @link_support: Link layer support layer * @head_room: Head room needed by link support layer * @layer: Lowest layer in CAIF stack * @rcv_fun: Receive function for CAIF stack. * * This function enroll a CAIF link layer into CAIF Stack and * expects the interface to be able to handle CAIF payload. * The link_support layer is used to add any Link Layer specific * framing. */ void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev, struct cflayer *link_support, int head_room, struct cflayer **layer, int (**rcv_func)( struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *)); #endif /* CAIF_DEV_H_ */ option value='1'>ssdiff
authorLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2017-01-29 13:50:06 -0800
commit39cb2c9a316e77f6dfba96c543e55b6672d5a37e (patch)
tree98fe974ee4e20121253de7f61fc8d01bdb3821c1 /sound/soc/codecs/wm2200.h
parent2c5d9555d6d937966d79d4c6529a5f7b9206e405 (diff)
drm/i915: Check for NULL i915_vma in intel_unpin_fb_obj()
I've seen this trigger twice now, where the i915_gem_object_to_ggtt() call in intel_unpin_fb_obj() returns NULL, resulting in an oops immediately afterwards as the (inlined) call to i915_vma_unpin_fence() tries to dereference it. It seems to be some race condition where the object is going away at shutdown time, since both times happened when shutting down the X server. The call chains were different: - VT ioctl(KDSETMODE, KD_TEXT): intel_cleanup_plane_fb+0x5b/0xa0 [i915] drm_atomic_helper_cleanup_planes+0x6f/0x90 [drm_kms_helper] intel_atomic_commit_tail+0x749/0xfe0 [i915] intel_atomic_commit+0x3cb/0x4f0 [i915] drm_atomic_commit+0x4b/0x50 [drm] restore_fbdev_mode+0x14c/0x2a0 [drm_kms_helper] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x80 [drm_kms_helper] drm_fb_helper_set_par+0x2d/0x60 [drm_kms_helper] intel_fbdev_set_par+0x18/0x70 [i915] fb_set_var+0x236/0x460 fbcon_blank+0x30f/0x350 do_unblank_screen+0xd2/0x1a0 vt_ioctl+0x507/0x12a0 tty_ioctl+0x355/0xc30 do_vfs_ioctl+0xa3/0x5e0 SyS_ioctl+0x79/0x90 entry_SYSCALL_64_fastpath+0x13/0x94 - i915 unpin_work workqueue: intel_unpin_work_fn+0x58/0x140 [i915] process_one_work+0x1f1/0x480 worker_thread+0x48/0x4d0 kthread+0x101/0x140 and this patch purely papers over the issue by adding a NULL pointer check and a WARN_ON_ONCE() to avoid the oops that would then generally make the machine unresponsive. Other callers of i915_gem_object_to_ggtt() seem to also check for the returned pointer being NULL and warn about it, so this clearly has happened before in other places. [ Reported it originally to the i915 developers on Jan 8, applying the ugly workaround on my own now after triggering the problem for the second time with no feedback. This is likely to be the same bug reported as https://bugs.freedesktop.org/show_bug.cgi?id=98829 https://bugs.freedesktop.org/show_bug.cgi?id=99134 which has a patch for the underlying problem, but it hasn't gotten to me, so I'm applying the workaround. ] Cc: Daniel Vetter <daniel.vetter@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/soc/codecs/wm2200.h')