/*
 * Copyright (C) ST-Ericsson AB 2010
 * Author:	Sjur Brendeland
 * License terms: GNU General Public License (GPL) version 2
 */

#ifndef CFSRVL_H_
#define CFSRVL_H_
#include <linux/list.h>
#include <linux/stddef.h>
#include <linux/types.h>
#include <linux/kref.h>
#include <linux/rculist.h>

struct cfsrvl {
	struct cflayer layer;
	bool open;
	bool phy_flow_on;
	bool modem_flow_on;
	bool supports_flowctrl;
	void (*release)(struct cflayer *layer);
	struct dev_info dev_info;
	void (*hold)(struct cflayer *lyr);
	void (*put)(struct cflayer *lyr);
	struct rcu_head rcu;
};

struct cflayer *cfvei_create(u8 linkid, struct dev_info *dev_info);
struct cflayer *cfdgml_create(u8 linkid, struct dev_info *dev_info);
struct cflayer *cfutill_create(u8 linkid, struct dev_info *dev_info);
struct cflayer *cfvidl_create(u8 linkid, struct dev_info *dev_info);
struct cflayer *cfrfml_create(u8 linkid, struct dev_info *dev_info,
				int mtu_size);
struct cflayer *cfdbgl_create(u8 linkid, struct dev_info *dev_info);

void cfsrvl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
		     int phyid);

bool cfsrvl_phyid_match(struct cflayer *layer, int phyid);

void cfsrvl_init(struct cfsrvl *service,
			u8 channel_id,
			struct dev_info *dev_info,
			bool supports_flowctrl);
bool cfsrvl_ready(struct cfsrvl *service, int *err);
u8 cfsrvl_getphyid(struct cflayer *layer);

static inline void cfsrvl_get(struct cflayer *layr)
{
	struct cfsrvl *s = container_of(layr, struct cfsrvl, layer);
	if (layr == NULL || layr->up == NULL || s->hold == NULL)
		return;

	s->hold(layr->up);
}

static inline void cfsrvl_put(struct cflayer *layr)
{
	struct cfsrvl *s = container_of(layr, struct cfsrvl, layer);
	if (layr == NULL || layr->up == NULL || s->hold == NULL)
		return;

	s->put(layr->up);
}
#endif				/* CFSRVL_H_ */
et/rose/rose_dev.c?h=nds-private-remove'>log</a><a href='/cgit.cgi/linux/net-next.git/tree/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>tree</a><a class='active' href='/cgit.cgi/linux/net-next.git/commit/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>commit</a><a href='/cgit.cgi/linux/net-next.git/diff/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>diff</a></td><td class='form'><form class='right' method='get' action='/cgit.cgi/linux/net-next.git/log/net/rose/rose_dev.c'>
<input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='07cd12945551b63ecb1a349d50a6d69d1d6feb4a'/><select name='qt'>
<option value='grep'>log msg</option>
<option value='author'>author</option>
<option value='committer'>committer</option>
<option value='range'>range</option>
</select>
<input class='txt' type='search' size='10' name='q' value=''/>
<input type='submit' value='search'/>
</form>
</td></tr></table>
<div class='path'>path: <a href='/cgit.cgi/linux/net-next.git/commit/?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>root</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>net</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net/rose?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>rose</a>/<a href='/cgit.cgi/linux/net-next.git/commit/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>rose_dev.c</a></div><div class='content'><div class='cgit-panel'><b>diff options</b><form method='get'><input type='hidden' name='h' value='nds-private-remove'/><input type='hidden' name='id' value='07cd12945551b63ecb1a349d50a6d69d1d6feb4a'/><table><tr><td colspan='2'/></tr><tr><td class='label'>context:</td><td class='ctrl'><select name='context' onchange='this.form.submit();'><option value='1'>1</option><option value='2'>2</option><option value='3' selected='selected'>3</option><option value='4'>4</option><option value='5'>5</option><option value='6'>6</option><option value='7'>7</option><option value='8'>8</option><option value='9'>9</option><option value='10'>10</option><option value='15'>15</option><option value='20'>20</option><option value='25'>25</option><option value='30'>30</option><option value='35'>35</option><option value='40'>40</option></select></td></tr><tr><td class='label'>space:</td><td class='ctrl'><select name='ignorews' onchange='this.form.submit();'><option value='0' selected='selected'>include</option><option value='1'>ignore</option></select></td></tr><tr><td class='label'>mode:</td><td class='ctrl'><select name='dt' onchange='this.form.submit();'><option value='0' selected='selected'>unified</option><option value='1'>ssdiff</option><option value='2'>stat only</option></select></td></tr><tr><td/><td class='ctrl'><noscript><input type='submit' value='reload'/></noscript></td></tr></table></form></div><table summary='commit info' class='commit-info'>
<tr><th>author</th><td>Tejun Heo &lt;tj@kernel.org&gt;</td><td class='right'>2017-01-26 16:47:28 -0500</td></tr>
<tr><th>committer</th><td>Tejun Heo &lt;tj@kernel.org&gt;</td><td class='right'>2017-01-26 16:47:28 -0500</td></tr>
<tr><th>commit</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>07cd12945551b63ecb1a349d50a6d69d1d6feb4a</a> (<a href='/cgit.cgi/linux/net-next.git/patch/net/rose/rose_dev.c?id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>patch</a>)</td></tr>
<tr><th>tree</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/tree/?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>75f65eba7eac9277971082a2d5a4cf1370562c0c</a> /<a href='/cgit.cgi/linux/net-next.git/tree/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>net/rose/rose_dev.c</a></td></tr>
<tr><th>parent</th><td colspan='2' class='oid'><a href='/cgit.cgi/linux/net-next.git/commit/net/rose/rose_dev.c?h=nds-private-remove&amp;id=7ce7d89f48834cefece7804d38fc5d85382edf77'>7ce7d89f48834cefece7804d38fc5d85382edf77</a> (<a href='/cgit.cgi/linux/net-next.git/diff/net/rose/rose_dev.c?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a&amp;id2=7ce7d89f48834cefece7804d38fc5d85382edf77'>diff</a>)</td></tr></table>
<div class='commit-subject'>cgroup: don't online subsystems before cgroup_name/path() are operational</div><div class='commit-msg'>While refactoring cgroup creation, a5bca2152036 ("cgroup: factor out
cgroup_create() out of cgroup_mkdir()") incorrectly onlined subsystems
before the new cgroup is associated with it kernfs_node.  This is fine
for cgroup proper but cgroup_name/path() depend on the associated
kernfs_node and if a subsystem makes the new cgroup_subsys_state
visible, which they're allowed to after onlining, it can lead to NULL
dereference.

The current code performs cgroup creation and subsystem onlining in
cgroup_create() and cgroup_mkdir() makes the cgroup and subsystems
visible afterwards.  There's no reason to online the subsystems early
and we can simply drop cgroup_apply_control_enable() call from
cgroup_create() so that the subsystems are onlined and made visible at
the same time.

Signed-off-by: Tejun Heo &lt;tj@kernel.org&gt;
Reported-by: Konstantin Khlebnikov &lt;khlebnikov@yandex-team.ru&gt;
Fixes: a5bca2152036 ("cgroup: factor out cgroup_create() out of cgroup_mkdir()") 
Cc: stable@vger.kernel.org # v4.6+
</div><div class='diffstat-header'><a href='/cgit.cgi/linux/net-next.git/diff/?h=nds-private-remove&amp;id=07cd12945551b63ecb1a349d50a6d69d1d6feb4a'>Diffstat</a> (limited to 'net/rose/rose_dev.c')</div><table summary='diffstat' class='diffstat'>