#ifndef _NET_DN_DEV_H #define _NET_DN_DEV_H struct dn_dev; struct dn_ifaddr { struct dn_ifaddr __rcu *ifa_next; struct dn_dev *ifa_dev; __le16 ifa_local; __le16 ifa_address; __u32 ifa_flags; __u8 ifa_scope; char ifa_label[IFNAMSIZ]; struct rcu_head rcu; }; #define DN_DEV_S_RU 0 /* Run - working normally */ #define DN_DEV_S_CR 1 /* Circuit Rejected */ #define DN_DEV_S_DS 2 /* Data Link Start */ #define DN_DEV_S_RI 3 /* Routing Layer Initialize */ #define DN_DEV_S_RV 4 /* Routing Layer Verify */ #define DN_DEV_S_RC 5 /* Routing Layer Complete */ #define DN_DEV_S_OF 6 /* Off */ #define DN_DEV_S_HA 7 /* Halt */ /* * The dn_dev_parms structure contains the set of parameters * for each device (hence inclusion in the dn_dev structure) * and an array is used to store the default types of supported * device (in dn_dev.c). * * The type field matches the ARPHRD_ constants and is used in * searching the list for supported devices when new devices * come up. * * The mode field is used to find out if a device is broadcast, * multipoint, or pointopoint. Please note that DECnet thinks * different ways about devices to the rest of the kernel * so the normal IFF_xxx flags are invalid here. For devices * which can be any combination of the previously mentioned * attributes, you can set this on a per device basis by * installing an up() routine. * * The device state field, defines the initial state in which the * device will come up. In the dn_dev structure, it is the actual * state. * * Things have changed here. I've killed timer1 since it's a user space * issue for a user space routing deamon to sort out. The kernel does * not need to be bothered with it. * * Timers: * t2 - Rate limit timer, min time between routing and hello messages * t3 - Hello timer, send hello messages when it expires * * Callbacks: * up() - Called to initialize device, return value can veto use of * device with DECnet. * down() - Called to turn device off when it goes down * timer3() - Called once for each ifaddr when timer 3 goes off * * sysctl - Hook for sysctl things * */ struct dn_dev_parms { int type; /* ARPHRD_xxx */ int mode; /* Broadcast, Unicast, Mulitpoint */ #define DN_DEV_BCAST 1 #define DN_DEV_UCAST 2 #define DN_DEV_MPOINT 4 int state; /* Initial state */ int forwarding; /* 0=EndNode, 1=L1Router, 2=L2Router */ unsigned long t2; /* Default value of t2 */ unsigned long t3; /* Default value of t3 */ int priority; /* Priority to be a router */ char *name; /* Name for sysctl */ int (*up)(struct net_device *); void (*down)(struct net_device *); void (*timer3)(struct net_device *, struct dn_ifaddr *ifa); void *sysctl; }; struct dn_dev { struct dn_ifaddr __rcu *ifa_list; struct net_device *dev; struct dn_dev_parms parms; char use_long; struct timer_list timer; unsigned long t3; struct neigh_parms *neigh_parms; __u8 addr[ETH_ALEN]; struct neighbour *router; /* Default router on circuit */ struct neighbour *peer; /* Peer on pointopoint links */ unsigned long uptime; /* Time device went up in jiffies */ }; struct dn_short_packet { __u8 msgflg; __le16 dstnode; __le16 srcnode; __u8 forward; } __packed; struct dn_long_packet { __u8 msgflg; __u8 d_area; __u8 d_subarea; __u8 d_id[6]; __u8 s_area; __u8 s_subarea; __u8 s_id[6]; __u8 nl2; __u8 visit_ct; __u8 s_class; __u8 pt; } __packed; /*------------------------- DRP - Routing messages ---------------------*/ struct endnode_hello_message { __u8 msgflg; __u8 tiver[3]; __u8 id[6]; __u8 iinfo; __le16 blksize; __u8 area; __u8 seed[8]; __u8 neighbor[6]; __le16 timer; __u8 mpd; __u8 datalen; __u8 data[2]; } __packed; struct rtnode_hello_message { __u8 msgflg; __u8 tiver[3]; __u8 id[6]; __u8 iinfo; __le16 blksize; __u8 priority; __u8 area; __le16 timer; __u8 mpd; } __packed; void dn_dev_init(void); void dn_dev_cleanup(void); int dn_dev_ioctl(unsigned int cmd, void __user *arg); void dn_dev_devices_off(void); void dn_dev_devices_on(void); void dn_dev_init_pkt(struct sk_buff *skb); void dn_dev_veri_pkt(struct sk_buff *skb); void dn_dev_hello(struct sk_buff *skb); void dn_dev_up(struct net_device *); void dn_dev_down(struct net_device *); int dn_dev_set_default(struct net_device *dev, int force); struct net_device *dn_dev_get_default(void); int dn_dev_bind_default(__le16 *addr); int register_dnaddr_notifier(struct notifier_block *nb); int unregister_dnaddr_notifier(struct notifier_block *nb); static inline int dn_dev_islocal(struct net_device *dev, __le16 addr) { struct dn_dev *dn_db; struct dn_ifaddr *ifa; int res = 0; rcu_read_lock(); dn_db = rcu_dereference(dev->dn_ptr); if (dn_db == NULL) { printk(KERN_DEBUG "dn_dev_islocal: Called for non DECnet device\n"); goto out; } for (ifa = rcu_dereference(dn_db->ifa_list); ifa != NULL; ifa = rcu_dereference(ifa->ifa_next)) if ((addr ^ ifa->ifa_local) == 0) { res = 1; break; } out: rcu_read_unlock(); return res; } #endif /* _NET_DN_DEV_H */ 5298220ece53423e38ba3aed'>92c715fca907686f5298220ece53423e38ba3aed (patch) tree286158fdad04c9b54955350abb95d4f1c0dc860a /net/netfilter/nfnetlink_acct.c parente6e7b48b295afa5a5ab440de0a94d9ad8b3ce2d0 (diff)
drm/atomic: Fix double free in drm_atomic_state_default_clear
drm_atomic_helper_page_flip and drm_atomic_ioctl set their own events in crtc_state->event. But when it's set the event is freed in 2 places. Solve this by only freeing the event in the atomic ioctl when it allocated its own event. This has been broken twice. The first time when the code was introduced, but only in the corner case when an event is allocated, but more crtc's were included by atomic check and then failing. This can mostly happen when you do an atomic modeset in i915 and the display clock is changed, which forces all crtc's to be included to the state. This has been broken worse by adding in-fences support, which caused the double free to be done unconditionally. [IGT] kms_rotation_crc: starting subtest primary-rotation-180 ============================================================================= BUG kmalloc-128 (Tainted: G U ): Object already free ----------------------------------------------------------------------------- Disabling lock debugging due to kernel taint INFO: Allocated in drm_atomic_helper_setup_commit+0x285/0x2f0 [drm_kms_helper] age=0 cpu=3 pid=1529 ___slab_alloc+0x308/0x3b0 __slab_alloc+0xd/0x20 kmem_cache_alloc_trace+0x92/0x1c0 drm_atomic_helper_setup_commit+0x285/0x2f0 [drm_kms_helper] intel_atomic_commit+0x35/0x4f0 [i915] drm_atomic_commit+0x46/0x50 [drm] drm_mode_atomic_ioctl+0x7d4/0xab0 [drm] drm_ioctl+0x2b3/0x490 [drm] do_vfs_ioctl+0x69c/0x700 SyS_ioctl+0x4e/0x80 entry_SYSCALL_64_fastpath+0x13/0x94 INFO: Freed in drm_event_cancel_free+0xa3/0xb0 [drm] age=0 cpu=3 pid=1529 __slab_free+0x48/0x2e0 kfree+0x159/0x1a0 drm_event_cancel_free+0xa3/0xb0 [drm] drm_mode_atomic_ioctl+0x86d/0xab0 [drm] drm_ioctl+0x2b3/0x490 [drm] do_vfs_ioctl+0x69c/0x700 SyS_ioctl+0x4e/0x80 entry_SYSCALL_64_fastpath+0x13/0x94 INFO: Slab 0xffffde1f0997b080 objects=17 used=2 fp=0xffff92fb65ec2578 flags=0x200000000008101 INFO: Object 0xffff92fb65ec2578 @offset=1400 fp=0xffff92fb65ec2ae8 Redzone ffff92fb65ec2570: bb bb bb bb bb bb bb bb ........ Object ffff92fb65ec2578: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec2588: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec2598: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25a8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25b8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25c8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25d8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object ffff92fb65ec25e8: 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5 kkkkkkkkkkkkkkk. Redzone ffff92fb65ec25f8: bb bb bb bb bb bb bb bb ........ Padding ffff92fb65ec2738: 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZ CPU: 3 PID: 180 Comm: kworker/3:2 Tainted: G BU 4.10.0-rc6-patser+ #5039 Hardware name: /NUC5PPYB, BIOS PYBSWCEL.86A.0031.2015.0601.1712 06/01/2015 Workqueue: events intel_atomic_helper_free_state [i915] Call Trace: dump_stack+0x4d/0x6d print_trailer+0x20c/0x220 free_debug_processing+0x1c6/0x330 ? drm_atomic_state_default_clear+0xf7/0x1c0 [drm] __slab_free+0x48/0x2e0 ? drm_atomic_state_default_clear+0xf7/0x1c0 [drm] kfree+0x159/0x1a0 drm_atomic_state_default_clear+0xf7/0x1c0 [drm] ? drm_atomic_state_clear+0x30/0x30 [drm] intel_atomic_state_clear+0xd/0x20 [i915] drm_atomic_state_clear+0x1a/0x30 [drm] __drm_atomic_state_free+0x13/0x60 [drm] intel_atomic_helper_free_state+0x5d/0x70 [i915] process_one_work+0x260/0x4a0 worker_thread+0x2d1/0x4f0 kthread+0x127/0x130 ? process_one_work+0x4a0/0x4a0 ? kthread_stop+0x120/0x120 ret_from_fork+0x29/0x40 FIX kmalloc-128: Object at 0xffff92fb65ec2578 not freed Fixes: 3b24f7d67581 ("drm/atomic: Add struct drm_crtc_commit to track async updates") Fixes: 9626014258a5 ("drm/fence: add in-fences support") Cc: <stable@vger.kernel.org> # v4.8+ Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1485854725-27640-1-git-send-email-maarten.lankhorst@linux.intel.com
Diffstat (limited to 'net/netfilter/nfnetlink_acct.c')